Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: re-ingest fails with service files #1151

Closed
jrwdunham opened this issue Jun 20, 2018 · 3 comments
Closed

Problem: re-ingest fails with service files #1151

jrwdunham opened this issue Jun 20, 2018 · 3 comments
Assignees
Labels
Type: bug A flaw in the code that causes the software to produce an incorrect or unexpected result.

Comments

@jrwdunham
Copy link
Contributor

A RuntimeError: maximum recursion depth exceeded error will be raised in the "Generate METS.xml document" micro-service when attempting a re-ingest of an AIP containing service files. This is in turn caused by an issue in mets-reader-writer: artefactual-labs/mets-reader-writer#37.

Note: recent attempts (2018-06) to re-create this issue have failed.

Related to artefactual/archivematica-storage-service#317

@jrwdunham jrwdunham self-assigned this Jun 20, 2018
@jrwdunham jrwdunham added the Type: bug A flaw in the code that causes the software to produce an incorrect or unexpected result. label Jun 20, 2018
@jrwdunham jrwdunham added this to the 1.8.0 milestone Jun 20, 2018
@jrwdunham
Copy link
Contributor Author

I have failed to re-create this issue using the following three methods. I am going to close it but suspect it may still be present but hidden somehow.

I tried the following with all three reingest-types: metadata-only, partial, and full:

  1. Create an AIP from SampleData/DigitizationOutput/ (which contains service files).
  2. Verify that USE=service files are documented in the AIP METS.
  3. Do a reingest_type re-ingest on the resulting AIP.
  4. Expect to see a failure at "Generate METS.xml document".
  5. Do not see a failure and be sad and happy at the same time.

@jrwdunham jrwdunham modified the milestones: 1.8.0, 1.7.2 Jun 20, 2018
@nickwilkinson
Copy link

Artefactual (internal)

@sromkey
Copy link
Contributor

sromkey commented Aug 22, 2018

I'm taking the milestone off of this since it wasn't so much fixed as not reproduced. Also closing the issue.

@sromkey sromkey closed this as completed Aug 22, 2018
@sromkey sromkey removed this from the 1.7.2 milestone Aug 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: bug A flaw in the code that causes the software to produce an incorrect or unexpected result.
Projects
None yet
Development

No branches or pull requests

3 participants