Skip to content

Commit

Permalink
Merge pull request #34 from artefactory/fix/read_from_gcs
Browse files Browse the repository at this point in the history
Fix/read from gcs
  • Loading branch information
griseau authored Oct 15, 2020
2 parents dcd7237 + 807b1fb commit 42a65be
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion IaC/modules/mlflow/log_pusher/main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,6 @@ resource "google_project_iam_member" "log_pusher_iap" {

resource "google_project_iam_member" "log_pusher_storage" {
project = var.project_id
role = "roles/storage.objectCreator"
role = "roles/storage.objectAdmin"
member = "serviceAccount:${google_service_account.log_pusher.email}"
}
6 changes: 3 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,9 @@ A tool to deploy a mostly serverless MLflow on a GCP project with one command

### Pre-requesites
- A GCP project on which you are owner
- Initialized gcloud SDK
- Initialized gcloud SDK with your owner account
- Docker engine running
- No app engine application running
- No app engine application running and no consent screen already setup

### Deploying
Fill out the `vars` file.
Expand All @@ -26,7 +26,7 @@ Fill out the `vars` file.
- Enables the necessary services
- Builds and pushes the MLFlow docker image
- Creates a private IP CloudSQL (MySQL) database for the tracking server
- Creates an AppEngine Flex service for the web UI, secured by IAP
- Creates an AppEngine Flex on the default service for the web UI, secured by IAP
- Manages all the network magic
- Creates the `mlflow-log-pusher` service account

Expand Down

0 comments on commit 42a65be

Please sign in to comment.