Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ItemParseError during creation of the D2SFile object #2

Open
artcom-net opened this issue Oct 7, 2020 · 2 comments
Open

ItemParseError during creation of the D2SFile object #2

artcom-net opened this issue Oct 7, 2020 · 2 comments
Assignees
@artcom-net
Labels
bug Something isn't working fixed_in_dev This issue was fixed in the dev branch

Comments

@artcom-net
Copy link
Owner

D2SFile('Varvar.d2s')
Traceback (most recent call last):
File "", line 1, in
File "/home/john/.local/lib/python3.8/site-packages/d2lib/files.py",
line 229, in init self.items = self._parse_items()
File "/home/john/.local/lib/python3.8/site-packages/d2lib/files.py",
line 83, in _parse_items item = Item(self._reader)
File "/home/john/.local/lib/python3.8/site-packages/d2lib/item.py",
line 146, in init self._parse_advanced()
File "/home/john/.local/lib/python3.8/site-packages/d2lib/item.py",
line 392, in _parse_advanced self.magic_attrs =
self._parse_magic_attrs() File
"/home/john/.local/lib/python3.8/site-packages/d2lib/item.py", line
284, in _parse_magic_attrs raise
ItemParseError( d2lib.errors.ItemParseError: Unknown magic attribute
id: 55
@artcom-net artcom-net self-assigned this Oct 7, 2020
@artcom-net
Copy link
Owner Author

Indeed, the "+X to Maximum Y Damage" attributes for cold and lightning are missing. IDs 51 and 55, respectively.

@artcom-net artcom-net added bug Something isn't working and removed analysis labels Oct 9, 2020
artcom-net added a commit that referenced this issue Oct 9, 2020
@artcom-net
Add missing magic attributes to the "+X to Maximum Y Damage" database…
15b0681 
… for cold and lightning

Fixes #2
@artcom-net
Copy link
Owner Author

Will be merged into master in version 1.0.0

@artcom-net artcom-net added the fixed_in_dev This issue was fixed in the dev branch label Oct 15, 2020
@artcom-net artcom-net mentioned this issue Oct 24, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@artcom-net artcom-net

Labels
bug Something isn't working fixed_in_dev This issue was fixed in the dev branch
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@artcom-net