Review and remove obsolete code

[knoepfel]

This issue has been migrated from https://cdcvs.fnal.gov/redmine/issues/6336 (FNAL account required)
Originally created by @drbenmorgan on 2014-05-23 12:16:27

---

Several areas of messagefacility appear to be no longer used, or to use obsolete APIs of fhicl-cpp.

• messagefacility/MessageLogger/LoggedErrorsSummary.h: Has incorrect header guards
• messagefacility/MessageService/ELtsErrorLog.icc: void ELtsItem tries to access private/protected data
• messagefacility/MessageService/MessageLoggerScribe.h: Extensive use of old APIs of fhiclcpp::ParameterSet, e.g. getParameter

Most problems are in template code so are never compiled directly, but nevertheless are still potentially available.

---

Subtasks:

• https://cdcvs.fnal.gov/redmine/issues/7018 (FNAL account required)

[knoepfel]

Comment by @chissg on 2014-05-27 17:28:59

---

We stipulate that there is a large amount of obsolete code in messagefacility: the list of such code was made last year. We are waiting for priority and effort assignment in order to do the full clean-up. We will bring this up again within our department to see if we can get effort assigned.

[knoepfel]

Comment by @drbenmorgan on 2014-09-09 12:28:18

---

In getting things working on Mac+Clang, I've created patches for the above reported issues. I've attached these as individual patches for each issue as they are atomic, but I can squash if you prefer. They can also be reviewed on "GitHub":https://github.com/LBNE/fnal-messagefacility/tree/clang-fixes