Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Where are -ee and -se modules? #34

Closed
bartoszmajsak opened this issue Sep 19, 2016 · 7 comments
Closed

Where are -ee and -se modules? #34

bartoszmajsak opened this issue Sep 19, 2016 · 7 comments

Comments

@bartoszmajsak
Copy link
Member

I've noticed that the structure has been changed with 2.0.0 version. What happened with the other modules? If it's desired we should probably also remote -root in such a case.

Also the name of -root pom is a bit misleading and it results with a weird blog post title and module name on arquillian.org - Arquillian Container Weld Root POM 2.0.0.Beta3 Released.

@bartoszmajsak
Copy link
Member Author

Would be great to clean it up @johnament @tremes.

@johnament
Copy link
Member

@bartoszmajsak I added that to make room for #32/#33 . I believe -ee and -se were removed and provide a consolidated module that can do both -se and -ee.

@johnament
Copy link
Member

What would you recommend we name the root level POM? just "arquillian-container-weld" ?

@tremes
Copy link
Contributor

tremes commented Sep 20, 2016

There is no need for ee and se modules. In general it was only code duplication. You can change the environment either programmatically or by configuration property as described in the README file!

I agree the root pom naming is currently weird since there is only one "impl" module but I think John suggested to introduce new integration tests.

@bartoszmajsak
Copy link
Member Author

as described in the README file!

ok, ok :) Missed that part.

@bartoszmajsak
Copy link
Member Author

bartoszmajsak commented Nov 2, 2016

Shall we deprecate this repository then? https://github.com/arquillian/arquillian-weld-embedded-1.1

@tremes
Copy link
Contributor

tremes commented Nov 2, 2016

Yes we can.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants