[Enhancement] Show error message for non-existent destination path

arnobpl · Jun 14, 2023 · 6b594a8 · 6b594a8
1 parent bb74552
commit 6b594a8
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 7 deletions.
diff --git a/SymlinkCreator/Properties/AssemblyInfo.cs b/SymlinkCreator/Properties/AssemblyInfo.cs
@@ -52,5 +52,5 @@
 // by using the '*' as shown below:
 // [assembly: AssemblyVersion("1.0.*")]
 
-[assembly: AssemblyVersion("1.2.1")]
-[assembly: AssemblyFileVersion("1.2.1")]
+[assembly: AssemblyVersion("1.2.2")]
+[assembly: AssemblyFileVersion("1.2.2")]
diff --git a/SymlinkCreator/core/SymlinkAgent.cs b/SymlinkCreator/core/SymlinkAgent.cs
@@ -42,8 +42,7 @@ public void CreateSymlinks()
             // check for destination path
             if (!Directory.Exists(_destinationPath))
             {
-                Debug.WriteLine("Destination path does not exist: " + _destinationPath);
-                return;
+                throw new FileNotFoundException("Destination path does not exist", _destinationPath);
             }
 
             // remove the last '\' character from the path if exists

diff --git a/SymlinkCreator/ui/mainWindow/MainWindow.xaml.cs b/SymlinkCreator/ui/mainWindow/MainWindow.xaml.cs
@@ -158,9 +158,15 @@ private void CreateSymlinksButton_OnClick(object sender, RoutedEventArgs e)
                 mainWindowViewModel.ShouldUseRelativePath,
                 mainWindowViewModel.ShouldRetainScriptFile);
 
-            symlinkAgent.CreateSymlinks();
-
-            MessageBox.Show("Execution completed.", "Done!", MessageBoxButton.OK, MessageBoxImage.Information);
+            try
+            {
+                symlinkAgent.CreateSymlinks();
+                MessageBox.Show("Execution completed.", "Done!", MessageBoxButton.OK, MessageBoxImage.Information);
+            }
+            catch (FileNotFoundException ex)
+            {
+                MessageBox.Show(ex.Message + ":\n" + ex.FileName, "Error!", MessageBoxButton.OK, MessageBoxImage.Error);
+            }
         }
 
         private void AboutButton_OnClick(object sender, RoutedEventArgs e)