Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Diffs of text containing tab characters? #11

Open
BlackKite84 opened this issue May 20, 2015 · 12 comments
Open

Diffs of text containing tab characters? #11

BlackKite84 opened this issue May 20, 2015 · 12 comments

Comments

@BlackKite84
Copy link

on Diff by Two Table withs Tab's the output has a
what does not belong there

output (updateChange) the
before Dog Days is too much

<tr>
                        <td class="columnText updateOriginal" style="width: 50%;">
                            Dog Days''                      </td>
                        <td class="columnText updateChange" style="width: 50%;"><span><br>                          Dog Days''                      </span></td>
                    </tr>

on view in browser i See a new line, the Text is not symmetric on line beginning

@arnab
Copy link
Owner

arnab commented May 20, 2015

Hi @BlackKite84 can you produce a jsfiddle with the problem?

@BlackKite84
Copy link
Author

@arnab
Copy link
Owner

arnab commented May 20, 2015

Huh, I am missing something here. You specified (in that jsfiddle):

  • the originalContainer as .updateOriginal
  • but both the changedContainer and diffContainer as .updateChange
  • text contents of both original and changed container look the same to me (Dog Days'')

Questions:

  • Where do you expect to see the diff (since the diffContainer is same as the changedContainer)?
  • What do you expect to see as the diff (since the text looks the same to me)?

@arnab
Copy link
Owner

arnab commented May 20, 2015

Also, the "title" of this issue is set to <br>. Could you please change that to the actual problem/question you are reporting/asking?

@BlackKite84
Copy link
Author

unbenannt

I overwrite the change Content with the diff (i will see only change and original)

http://jsfiddle.net/pytm9ueL/2/

A new line (
)

@arnab
Copy link
Owner

arnab commented May 20, 2015

Add debug: true to when you call prettyTextDiff: http://jsfiddle.net/pytm9ueL/4/

This will show you what this library found. Looks like the underlying Google diff-match-patch library shows the "↵ " also as a diff.

@BlackKite84
Copy link
Author

and why "Enter" i use Tab

@arnab
Copy link
Owner

arnab commented May 20, 2015

Like I said, what you are seeing is coming from the underlying library. Please ask your question there: https://code.google.com/p/google-diff-match-patch/

@arnab arnab changed the title <br> Diffs of text containing tab characters? May 20, 2015
@BlackKite84
Copy link
Author

I have Fix ist with

        } else {
          original = $(settings.originalContainer, this).text().trim();
          changed = $(settings.changedContainer, this).text().trim();
        }

@jbeyer05
Copy link

I am running into the same issue that @BlackKite84 was seeing. I have two divs that appear to have identical content (including whitespace). If I pass parameters via originalContainer and changedContainer, PrettyTextDiff appears to pass slightly different strings (different in their whitespace) to google-diff-match-patch. Here is the result of a call to .prettyTextDiff( ) when I use originalContainer and changedContainer parameters. Note the <br>'s that are inserted at the beginning and end of .immutable-clause-pretty-diff

Screen Shot 2019-06-24 at 7 28 19 PM

Screen Shot 2019-06-24 at 7 28 42 PM

And here is the result of a call to .prettyTextDiff( ) when I use originalContent and changedContent parameters with the trim( ) function, as suggested by @BlackKite84. It works as expected:

Screen Shot 2019-06-24 at 7 30 41 PM

Screen Shot 2019-06-24 at 7 30 53 PM

@jbeyer05
Copy link

jbeyer05 commented Jun 24, 2019

It appears that if there are matching newline characters inside the originalContent and changedContent divs, google-diff-match-patch passes the newline character back, but PrettyTextDiff converts said newline character to a <br> here

I'm not sure if it would break things for other users, but it seems like substituting <br>s for newline characters may not be necessary.

@parallels999
Copy link

I think that any problems like \t, \b, or whitespace would be solved by using <pre></pre>

Example: https://jsfiddle.net/ybz8enwk
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants