Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conflict arktype@^1.0.28-alpha - sass@^1.69.7 #900

Closed
SAROND-DEV opened this issue Jan 12, 2024 · 3 comments · Fixed by #901
Closed

Conflict arktype@^1.0.28-alpha - sass@^1.69.7 #900

SAROND-DEV opened this issue Jan 12, 2024 · 3 comments · Fixed by #901
Assignees
Labels
bug Something isn't working

Comments

@SAROND-DEV
Copy link

Report a bug

Using arktype with sass an error occurs Maximum call stack size exceeded
Sass add properties to the global Function, which causes an infinite loop in the method deepFreeze(Function)

I understand that the problem is on the sass, but I think it is unlikely that something will change in the package in the near future. Is there any way to fix this on your side?

// file sass-dart.js

Function.prototype.call$0 = function () {
  return this();
};
Function.prototype.call$1 = function (a) {
  return this(a);
};
Function.prototype.call$2 = function (a, b) {
  return this(a, b);
};
Function.prototype.call$3$1 = function (a) {
  return this(a);
};

🔎 Search Terms

deepFreeze
Function

🧩 Context

  • ArkType version: 1.0.28-alpha
  • TypeScript version (4.8+): "^5.3.3"
  • Other context you think may be relevant (Node version, OS, etc.): Node 16, Windows 10

🧑‍💻 Repro

https://stackblitz.com/edit/stackblitz-starters-uicmza?file=index.js

require('sass');
require('arktype');
@SAROND-DEV SAROND-DEV added the bug Something isn't working label Jan 12, 2024
@github-project-automation github-project-automation bot moved this to To do in arktypeio Jan 12, 2024
@SAROND-DEV SAROND-DEV changed the title RangeError: Maximum call stack size exceeded Conflict arktype@^1.0.28-alpha - sass@^1.69.7 Jan 12, 2024
@ssalbdivad
Copy link
Member

This will definitely be fixed in beta since deepFreeze has been removed.

I don't think it's particularly critical in alpha either and would consider releasing a patch build if that would be immediately useful.

@SAROND-DEV
Copy link
Author

Thanks, it would be great to get a patch.

@ssalbdivad
Copy link
Member

@SAROND-DEV Give [email protected] a shot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done (merged or closed)
Development

Successfully merging a pull request may close this issue.

2 participants