diff --git a/src/Arkivverket.Arkade.Core.Tests/TestData/Noark5/Version5_5/arkivuttrekk.xml b/src/Arkivverket.Arkade.Core.Tests/TestData/Noark5/Version5_5/arkivuttrekk.xml index 44e34c3ca..92e9c22a4 100644 --- a/src/Arkivverket.Arkade.Core.Tests/TestData/Noark5/Version5_5/arkivuttrekk.xml +++ b/src/Arkivverket.Arkade.Core.Tests/TestData/Noark5/Version5_5/arkivuttrekk.xml @@ -67,7 +67,7 @@ Noark 5 - 5.5 + 5.0 diff --git a/src/Arkivverket.Arkade.Core.Tests/Testing/Noark5/TestUtil.cs b/src/Arkivverket.Arkade.Core.Tests/Testing/Noark5/TestUtil.cs index 9eb8fd8ee..a332bcd8f 100644 --- a/src/Arkivverket.Arkade.Core.Tests/Testing/Noark5/TestUtil.cs +++ b/src/Arkivverket.Arkade.Core.Tests/Testing/Noark5/TestUtil.cs @@ -24,7 +24,7 @@ public static Archive CreateArchiveExtractionV5_5(string testdataDirectory) return new Base.ArchiveBuilder() .WithArchiveType(ArchiveType.Noark5) .WithWorkingDirectoryExternalContent(workingDirectory) - .WithArchiveDetails("5.5") + .WithArchiveDetails("5.0") .Build(); } diff --git a/src/Arkivverket.Arkade.Core/Base/ArkadeTestNameProvider.cs b/src/Arkivverket.Arkade.Core/Base/ArkadeTestNameProvider.cs index 163f62b98..75e8b862a 100644 --- a/src/Arkivverket.Arkade.Core/Base/ArkadeTestNameProvider.cs +++ b/src/Arkivverket.Arkade.Core/Base/ArkadeTestNameProvider.cs @@ -19,10 +19,7 @@ public static string GetDisplayName(TestId testId, SupportedLanguage language) private static string GetDisplayName(TestId testId, CultureInfo culture) { - string resourceDisplayNameKey = testId.ToString().Replace('.', '_'); - - if (testId.Version.Equals("5.5")) - resourceDisplayNameKey = $"{resourceDisplayNameKey}v5_5"; + string resourceDisplayNameKey = $"{testId}{testId.Version}".Replace('.', '_'); string testName = ArkadeTestDisplayNames.ResourceManager.GetString(resourceDisplayNameKey, culture); diff --git a/src/Arkivverket.Arkade.Core/Resources/ArkadeTestDisplayNames.Designer.cs b/src/Arkivverket.Arkade.Core/Resources/ArkadeTestDisplayNames.Designer.cs index 2b932d54f..70bc19567 100644 --- a/src/Arkivverket.Arkade.Core/Resources/ArkadeTestDisplayNames.Designer.cs +++ b/src/Arkivverket.Arkade.Core/Resources/ArkadeTestDisplayNames.Designer.cs @@ -648,9 +648,9 @@ public static string N5_35 { /// /// Looks up a localized string similar to Number of parties. /// - public static string N5_35v5_5 { + public static string N5_35v5_0 { get { - return ResourceManager.GetString("N5_35v5_5", resourceCulture); + return ResourceManager.GetString("N5_35v5_0", resourceCulture); } } diff --git a/src/Arkivverket.Arkade.Core/Resources/ArkadeTestDisplayNames.nb-NO.resx b/src/Arkivverket.Arkade.Core/Resources/ArkadeTestDisplayNames.nb-NO.resx index a846bbbe9..0a4dcf668 100644 --- a/src/Arkivverket.Arkade.Core/Resources/ArkadeTestDisplayNames.nb-NO.resx +++ b/src/Arkivverket.Arkade.Core/Resources/ArkadeTestDisplayNames.nb-NO.resx @@ -312,7 +312,7 @@ Antall saksparter - + Antall parter diff --git a/src/Arkivverket.Arkade.Core/Resources/ArkadeTestDisplayNames.resx b/src/Arkivverket.Arkade.Core/Resources/ArkadeTestDisplayNames.resx index 1a0f088e0..62dcd295e 100644 --- a/src/Arkivverket.Arkade.Core/Resources/ArkadeTestDisplayNames.resx +++ b/src/Arkivverket.Arkade.Core/Resources/ArkadeTestDisplayNames.resx @@ -313,7 +313,7 @@ Number of case parties - + Number of parties diff --git a/src/Arkivverket.Arkade.Core/Testing/Noark5/N5_35_NumberOfCaseParts.cs b/src/Arkivverket.Arkade.Core/Testing/Noark5/N5_35_NumberOfCaseParts.cs index 90ca6d3ef..d6ee6d0dc 100644 --- a/src/Arkivverket.Arkade.Core/Testing/Noark5/N5_35_NumberOfCaseParts.cs +++ b/src/Arkivverket.Arkade.Core/Testing/Noark5/N5_35_NumberOfCaseParts.cs @@ -16,14 +16,7 @@ public class N5_35_NumberOfCaseParts : Noark5XmlReaderBaseTest private string GetTestVersion() { - string standardVersion = archive.Details.ArchiveStandard; - - if (standardVersion.Equals("5.5")) - { - return "5.5"; - } - - return standardVersion; + return archive.Details.ArchiveStandard; } public N5_35_NumberOfCaseParts(Archive archive) @@ -91,7 +84,7 @@ protected override void ReadElementValueEvent(object sender, ReadElementEventArg protected override void ReadEndElementEvent(object sender, ReadElementEventArgs eventArgs) { - if (archive.Details.ArchiveStandard.Equals("5.5")) + if (archive.Details.ArchiveStandard.Equals("5.0")) { CountPartsForVersion5_5(eventArgs); } diff --git a/src/Arkivverket.Arkade.Core/Util/TestId.cs b/src/Arkivverket.Arkade.Core/Util/TestId.cs index 81061aef0..aa85afa1a 100644 --- a/src/Arkivverket.Arkade.Core/Util/TestId.cs +++ b/src/Arkivverket.Arkade.Core/Util/TestId.cs @@ -20,11 +20,11 @@ public class TestId : IComparable { TestKind.Unidentified, "U" }, }; - public TestId(TestKind testKind, uint number, string version = "5.0") + public TestId(TestKind testKind, uint number, string version = default) { Kind = testKind; Number = number; - Version = version; + Version = $"v{version}"; } public static TestId Create(string testId)