Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible change in manager process #7

Open
sonic182 opened this issue Apr 28, 2021 · 1 comment
Open

Possible change in manager process #7

sonic182 opened this issue Apr 28, 2021 · 1 comment

Comments

@sonic182
Copy link

sonic182 commented Apr 28, 2021

It is possible that this line

use GenServer, restart: :transient

is the one that make managers process not to be restarted, when normal shutdown of process used in singleton?

when scaling down one service, my single process gets down and doesn't get up in remaining nodes of service... I think is because it gets detected as normal shutdown instead of abruptly

https://hexdocs.pm/elixir/Supervisor.html#module-restart-values-restart

If so, would be nice to pass the restart value by config, when starting the singleton

@arjan
Copy link
Owner

arjan commented Apr 28, 2021

Yes indeed, transient causes the process only to be restarted if it exited abnormally.
PR welcome to change this :-)

@sonic182 sonic182 mentioned this issue Apr 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants