feat: Use unique name for csrf cookie #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dg183
reviewed
Nov 8, 2024
ajhfok
force-pushed
the
ajhfok/csrf-check-failed-message
branch
4 times, most recently
from
aecd897
to
410a58a
Compare
ajhfok
commented
Nov 8, 2024
ajhfok
force-pushed
the
ajhfok/csrf-check-failed-message
branch
2 times, most recently
from
ed54814
to
24630c4
Compare
ajhfok
changed the title
ajhfok
force-pushed
the
ajhfok/csrf-check-failed-message
branch
from
24630c4
to
81a177b
Compare
ajhfok
requested review from
kellyma2,
kthommandra and
a team
as code owners
When multiple tabs attempt an oidc auth flow, they will the oidc_state_csrf cookie will get overriden, causing a race condition where one tab will succeed and all others will fail horribly. This feature aims to create a unique oidc_state_csrf cookie per tab. This means each tab will complete its auth flow. the authservice_session cookie may be overriden, but that should be ok.
ajhfok
force-pushed
the
ajhfok/csrf-check-failed-message
branch
from
81a177b
to
bb0c5c0
Compare
kellyma2
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If multiple tabs attempt to follow an auth flow, they will override eachother's oidc_csrf cookie. This extends beyond a mild annoyance since the client loses all context of the original URL of that tab, and is instead left with a useless error url from oidc-authservice.
This PR aims to make the name of the oidc_csrf dynamic by adding a random suffix to it. This functionality is controlled via an application setting. When enabled, each tab will be able to complete an auth flow, since they will all have a unique oidc_csrf cookie.