Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(anta): Refactor VerifyLLDPNeighbors test for nicer failure message #915

Merged
merged 6 commits into from
Nov 13, 2024
Merged

refactor(anta): Refactor VerifyLLDPNeighbors test for nicer failure message #915

merged 6 commits into from
Nov 13, 2024

Conversation

vitthalmagadum
Copy link
Collaborator

@vitthalmagadum vitthalmagadum commented Nov 6, 2024 •
edited by carl-baillargeon
Loading

Description

Refactor VerifyLLDPNeighbors test for nicer failure message

Related to #587 #388

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have run pre-commit for code linting and typing (pre-commit run)
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes (tox -e testenv)

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Nov 6, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #915 will not alter performance

Comparing vitthalmagadum:feat/LLDP (e1e53bb) with main (2931fe1)

Summary

✅ 8 untouched benchmarks

@vitthalmagadum vitthalmagadum mentioned this pull request Nov 7, 2024
Open
31 tasks
carl-baillargeon
carl-baillargeon approved these changes Nov 8, 2024
View reviewed changes
Copy link
Contributor

@carl-baillargeon carl-baillargeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

gmuloc
gmuloc requested changes Nov 12, 2024
View reviewed changes
anta/input_models/connectivity.py Outdated Show resolved Hide resolved
anta/tests/connectivity.py Outdated Show resolved Hide resolved
anta/tests/connectivity.py Show resolved Hide resolved
gmuloc
gmuloc approved these changes Nov 13, 2024
View reviewed changes
Copy link
Collaborator

@gmuloc gmuloc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks a lot @vitthalmagadum

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 13, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@gmuloc gmuloc merged commit 8ac4477 into aristanetworks:main Nov 13, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carl-baillargeon carl-baillargeon carl-baillargeon approved these changes

@gmuloc gmuloc gmuloc approved these changes

Assignees

@vitthalmagadum vitthalmagadum

Labels
rn: refactor(anta)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vitthalmagadum @gmuloc @carl-baillargeon