fix(anta.tests): Second round of cleaning up BGP tests module #914
+692
−1,383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
31 tasks
CodSpeed Performance ReportMerging #914 will not alter performanceComparing Summary
|
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
vitthalmagadum
force-pushed
the
fix/bgp_modules_v2
branch
from
a27b153
to
b66f090
Compare
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
vitthalmagadum
force-pushed
the
fix/bgp_modules_v2
branch
from
7a5f189
to
5ad4b4e
Compare
| "'received_routes': {'192.0.254.31/32': 'Not found', '192.0.255.4/32': {'valid': False, 'active': False}}}}, " | ||
| "'172.30.11.5': {'default': {'advertised_routes': {'192.0.254.31/32': 'Not found', '192.0.254.5/32': {'valid': True, 'active': False}}, " | ||
| "'received_routes': {'192.0.254.3/32': {'valid': False, 'active': True}, '192.0.255.41/32': 'Not found'}}}}}" | ||
| "Peer: 172.30.11.1 VRF: default Advertised route: 192.0.254.3/32 - Invalid/inactive; Valid: False, Active: True", |
There was a problem hiding this comment.
Let's remove Invalid/inactive since it's redundant:
Suggested change
| "Peer: 172.30.11.1 VRF: default Advertised route: 192.0.254.3/32 - Invalid/inactive; Valid: False, Active: True", | |
| "Peer: 172.30.11.1 VRF: default Advertised route: 192.0.254.3/32 - Valid: False, Active: True", |
…yBgpRouteMaps, VerifyBGPPeerRouteLimit
for more information, see https://pre-commit.ci
vitthalmagadum
force-pushed
the
fix/bgp_modules_v2
branch
from
c2cba1e
to
d48f57c
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactoring BGP tests module to address the following issues:
WARNING: NEED TO MERGE #888 BEFORE
To-do list: