fix(anta.tests): Cleaning up BGP tests module

[vitthalmagadum]

Description

Refactoring BGP tests module to address the following issues:

• Refactor to reduce the number of lines in bgp test module #865
• Extra attributes should be forbidden in nested Input models #809
• Extend VerifyBGPPeerCount or VerifyBGPPeersHealth test to also checks for a minimum established time for BGP session #635
• Have nicer result failure messages #587
• Enhancement: Input subclasses refactoring #388

Focusing on VerifyBGPPeerCount, VerifyBGPPeersHealth, VerifyBGPSpecificPeers

Task list:

• Update unit tests for VerifyBGPPeersHealth & VerifyBGPSpecificPeers
  • Success
  • VRF not configured
  • No peers found
  • Session not established
  • AFI/SAFI not negotiated
  • TCP session queues not empty if check_tcp_queues is True
• Add unit tests for check_bgp_neighbor_capability
• Add unit tests for format_data

Changes

• Updated InQ & OutQ steps as or evaluates lazily, meaning if the first part (InQ := value) != 0 is True, the second part (OutQ := value) != 0 will not be evaluated, results OutQ is never assigned, leading to a NameError.
• In VerifyBGPSpecificPeers test, added check for peers have correct AFI/SAFI negotiated.
• Added _check_bgp_neighbor_capability to bgp module as intended to BGP module only.

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
92.1% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[carl-baillargeon]

Duplicate of #888