feat(anta): Added the test case for verify BGP peer group of the BGP IPv4 peer(s) #815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaheshGSLAB
reviewed
Sep 6, 2024
anta/tests/routing/bgp.py
Outdated
Comment on lines
1461
to
1496
| peer = command.params.peer | ||
| vrf = command.params.vrf | ||
| peer_group = input_entry.peer_group |
There was a problem hiding this comment.
you can collect the peer and vrf from input_entry
anta/tests/routing/bgp.py
Outdated
| failure_log = f"Expected `{peer_group}` as the configured peer-group, but found `{actual_peer_group}` instead." | ||
| if not actual_peer_group: | ||
| failure_log = "Peer-group not configured." | ||
| failures[peer] = failure_log |
There was a problem hiding this comment.
so when peer not configured we are giving the vrf information but while it is not correct we are missing it to add vrf information. Please correct it.
There was a problem hiding this comment.
Updated. Thanks!!
vitthalmagadum
force-pushed
the
issue_810
branch
from
54096a4
to
07ae814
Compare
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
vitthalmagadum
force-pushed
the
issue_810
branch
from
63da029
to
7529a1d
Compare
MaheshGSLAB
reviewed
Sep 24, 2024
MaheshGSLAB
approved these changes
Sep 30, 2024
MaheshGSLAB
reviewed
Oct 4, 2024
|
CodSpeed Performance ReportMerging #815 will not alter performanceComparing Summary
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Verifies BGP peer group of the BGP IPv4 peer(s).
Fixes #810
Checklist:
pre-commit run)tox -e testenv)