Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mysql binary type error #751

Closed
calvin2021y opened this issue Apr 29, 2022 · 3 comments · May be fixed by #869
Closed

mysql binary type error #751

calvin2021y opened this issue Apr 29, 2022 · 3 comments · May be fixed by #869

Comments

@calvin2021y
Copy link

calvin2021y commented Apr 29, 2022 •
edited
Loading

varbinary is work

table "test" {
	schema  = schema.test
	column "bin" {
		type = varbinary(32)
		null = false
	}
}
schema "test" {
	charset = "utf8mb4"
	collate = "utf8mb4_unicode_ci"
}
CREATE TABLE `test`.`test` (`bin` varbinary(32) NOT NULL)

binary is not work

table "test" {
	schema  = schema.test
	column "bin" {
		type = binary(32)
		null = false
	}
}
schema "test" {
	charset = "utf8mb4"
	collate = "utf8mb4_unicode_ci"
}
CREATE TABLE `test`.`test` (`bin` binary NOT NULL)

there is no fixed size 32 in SQL.

Test on today master branch.
@a8m
Copy link
Member

a8m commented May 1, 2022

Hey @calvin2021y 👋
Thanks for reporting this issue. The fix should be simple.

Would you like to contribute this fix to Atlas? I can support you on our Discord server, but if not that's also fine, I can handle this later today or tomorrow.

@calvin2021y
Copy link
Author

Sorry for late response.

I will give a a try after I setup my discord account, in this week.

@calvin2021y
Copy link
Author

confirm fixed.

@calvin2021y calvin2021y mentioned this issue Jun 17, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

sql/mysql: fix binary with size calvin2021y/atlas
2 participants
@a8m @calvin2021y