Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mature Themes Setting in Webclient #403

Closed
AntumDeluge opened this issue Dec 18, 2021 · 3 comments
Closed

Mature Themes Setting in Webclient #403

AntumDeluge opened this issue Dec 18, 2021 · 3 comments
Assignees
Labels
component: webclient Related to the web client. type: feature request Desired features and ideas.

Comments

@AntumDeluge
Copy link
Member

AntumDeluge commented Dec 18, 2021

💡 Describe your idea

The web client needs a setting to disable mature & violent images, like the Java client has.

Edit: Included in #254.

@AntumDeluge AntumDeluge added component: webclient Related to the web client. type: feature request Desired features and ideas. labels Dec 18, 2021
@AntumDeluge AntumDeluge self-assigned this Dec 18, 2021
@nhnb
Copy link
Member

nhnb commented Dec 20, 2021

It is not as simple as adding a setting:

  • At the moment the client tries to load a potential non existing image. It is fine as long as the error is locally. It is not fine to have tons of 404 errors in the server log.
  • "Mature" is a word, that most non-native speaker in Germany do not know. Blood is well known.
  • We might want: showing nude players off by default, but showing blood+corpses on by default
  • We need a way to store this setting on the server.

@AntumDeluge
Copy link
Member Author

Updated Java client to use a unique setting for disabling nude characters: 874a117

Let me know if that label is good.

We need a way to store this setting on the server.

This setting has to be unique to each user account, right? How would a web-based app normally do something like that? Wouldn't they use a cookie stored on the user machine? I'm guessing that we don't want to use cookies with the web client. So do we need to add database columns for user settings?

@AntumDeluge
Copy link
Member Author

AntumDeluge commented Mar 9, 2022

Until we have proper settings storage, blood can be disabled with noblood query string. Example: ?char=mychar&noblood

Related commits:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: webclient Related to the web client. type: feature request Desired features and ideas.
Projects
None yet
Development

No branches or pull requests

2 participants