Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove JNLP #23

Open
ghost opened this issue Oct 24, 2020 · 0 comments
Open

Remove JNLP #23

ghost opened this issue Oct 24, 2020 · 0 comments

Comments

@ghost
Copy link

ghost commented Oct 24, 2020

Contributions and improvements are usually about making additions, but sometimes we need to remove things in order to move forward.

Marauroa has this dependency on jnlp.jar. It used to be part of JDK but has been removed and is not to be found in Maven repositories. I think it's actually non-free software.
This was also probably the main reason why the "mavenization" of Marauroa was not successful.
Since Stendhal is no longer using Java Web Start, I propose to remove jnlp.jar along with the WebstartPersistence class from Marauroa.
If we are concerned that other projects might still want it, we could extract a separate project, "marauroa-ws", which would only contain that class and would only depend on jnlp.jar.
Also we might want to do this in Marauroa 4.0, as doing it in 3.9.x would unexpectedly break the API.

Benefit: this would allow us to move to declarative dependency management, perhaps through Ivy at first, or directly through Maven.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

0 participants