Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize the content of the list of archived workflows sent to front-end #12030

Closed
terrytangyuan opened this issue Oct 18, 2023 · 5 comments
Closed
Labels
area/api Argo Server API area/workflow-archive P2 Important. All bugs with >=3 thumbs up that aren’t P0 or P1, plus: Any other bugs deemed important type/bug type/regression Regression from previous behavior (a specific type of bug)

Comments

@terrytangyuan
Copy link
Member

terrytangyuan commented Oct 18, 2023

Summary

Currently, we retrieve the list of both live workflows and archived workflows where each workflow contains the entire workflow object, including spec, status, etc. Some of this information may not be needed for the workflow list view (they are only required for workflow details page), but they take up a lot of memory, which might overload the UI.

We should only return the list of workflows with the required information from each workflow object.

Related #12025


Message from the maintainers:

Love this enhancement proposal? Give it a 👍. We prioritise the proposals with the most 👍.

@agilgur5
Copy link
Contributor

We do some server-side filtering on the fields already

We should only return the list of workflows with the required information from each workflow object.

Since it is the same API used by everything else, this feature is for more server-side filtering that the UI could use?

@agilgur5 agilgur5 added area/api Argo Server API area/ui labels Oct 18, 2023
@terrytangyuan
Copy link
Member Author

Correct

@agilgur5
Copy link
Contributor

agilgur5 commented Jan 29, 2024

So I didn't think there was much room to improve this (but I haven't looked too closely), but I did discover a possible performance regression with this on the Archived Workflow side: #11121 (comment) -- all fields are getting selected there

@terrytangyuan
Copy link
Member Author

Not needed anymore due to improvements in #13021

@terrytangyuan terrytangyuan closed this as not planned Won't fix, can't repro, duplicate, stale Aug 2, 2024
@agilgur5
Copy link
Contributor

Actually, this was resolved in #12912 per the regression I noted above

@agilgur5 agilgur5 changed the title Optimize the list of workflows sent to front-end Optimize the content of the list of archived workflows sent to front-end Sep 20, 2024
@agilgur5 agilgur5 added type/bug type/regression Regression from previous behavior (a specific type of bug) P2 Important. All bugs with >=3 thumbs up that aren’t P0 or P1, plus: Any other bugs deemed important and removed type/feature Feature request labels Sep 20, 2024
@argoproj argoproj locked as resolved and limited conversation to collaborators Sep 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/api Argo Server API area/workflow-archive P2 Important. All bugs with >=3 thumbs up that aren’t P0 or P1, plus: Any other bugs deemed important type/bug type/regression Regression from previous behavior (a specific type of bug)
Projects
None yet
Development

No branches or pull requests

2 participants