From 49066b16b13e5650a53e65d8ca7b73b0ebe8ff55 Mon Sep 17 00:00:00 2001
From: Anton Gilgur <agilgur5@gmail.com>
Date: Wed, 17 Jan 2024 18:01:17 -0500
Subject: [PATCH] self review fixes

Signed-off-by: Anton Gilgur <agilgur5@gmail.com>
---
 ui/src/app/event-sources/event-source-log-viewer.tsx            | 1 +
 ui/src/app/modals/version.ts                                    | 2 +-
 ui/src/app/shared/components/parameters-input.tsx               | 1 +
 .../app/shared/components/resource-editor/resource-editor.tsx   | 1 +
 4 files changed, 4 insertions(+), 1 deletion(-)

diff --git a/ui/src/app/event-sources/event-source-log-viewer.tsx b/ui/src/app/event-sources/event-source-log-viewer.tsx
index 3fccb17e8e7b..7bfe4b3431eb 100644
--- a/ui/src/app/event-sources/event-source-log-viewer.tsx
+++ b/ui/src/app/event-sources/event-source-log-viewer.tsx
@@ -2,6 +2,7 @@ import * as React from 'react';
 import {useEffect, useState} from 'react';
 import {Observable} from 'rxjs';
 import {filter, map} from 'rxjs/operators';
+
 import {EventSource} from '../../models';
 import {ErrorNotice} from '../shared/components/error-notice';
 import {Links} from '../shared/components/links';
diff --git a/ui/src/app/modals/version.ts b/ui/src/app/modals/version.ts
index 19628859f7b0..9e12c68d8a90 100644
--- a/ui/src/app/modals/version.ts
+++ b/ui/src/app/modals/version.ts
@@ -1,6 +1,6 @@
 export function majorMinor(version: string) {
     if (version.includes('.')) {
-        return version.substring(0, version.lastIndexOf('.') - 1);
+        return version.substring(0, version.lastIndexOf('.'));
     }
     return version;
 }
diff --git a/ui/src/app/shared/components/parameters-input.tsx b/ui/src/app/shared/components/parameters-input.tsx
index 0651f0bc3140..56c4eddaf612 100644
--- a/ui/src/app/shared/components/parameters-input.tsx
+++ b/ui/src/app/shared/components/parameters-input.tsx
@@ -1,5 +1,6 @@
 import {Select, Tooltip} from 'argo-ui';
 import React from 'react';
+
 import {Parameter} from '../../../models';
 import {Utils} from '../utils';
 
diff --git a/ui/src/app/shared/components/resource-editor/resource-editor.tsx b/ui/src/app/shared/components/resource-editor/resource-editor.tsx
index 53d972f221ed..52f7132c067a 100644
--- a/ui/src/app/shared/components/resource-editor/resource-editor.tsx
+++ b/ui/src/app/shared/components/resource-editor/resource-editor.tsx
@@ -1,6 +1,7 @@
 import * as kubernetes from 'argo-ui/src/models/kubernetes';
 import * as React from 'react';
 import {useState} from 'react';
+
 import {Button} from '../button';
 import {ErrorNotice} from '../error-notice';
 import {ObjectEditor} from '../object-editor';