diff --git a/.spelling b/.spelling index 9f31a45285f0..def637016761 100644 --- a/.spelling +++ b/.spelling @@ -52,13 +52,11 @@ CronWorkflow CronWorkflows DataDog Dataflow -DeleteObject DevOps Dex EditorConfig EtcD EventRouter -GSoC GitOps Github Golang @@ -74,7 +72,6 @@ InsideBoard Invocators IAM-based Istio -J.P. Jemison JetBrains KNative @@ -99,8 +96,6 @@ Node.JS. OAuth OAuth2 Okta -parameterize -parameterized parameterizing PDBs PProf @@ -119,17 +114,13 @@ Singer.io Snyk Sumit Tekton -Tianchu Traefik TripAdvisor VSCode Valasek Webhooks Welch -`CronTab` -`OnFailure` a.m. -alexec anded apis architecting @@ -138,7 +129,6 @@ args async auth backend -blkperl boolean booleans buildkit @@ -147,8 +137,6 @@ config cpu cron daemoned -dev-container -dinever dockershim dropdown e.g. @@ -178,8 +166,6 @@ localhost memoization memoized memoizing -mentee -mentees minikube mutex namespace @@ -196,15 +182,9 @@ roadmap runtime runtimes sandboxed -sarabala1979 -simster7 stateful stderr -tczhao -terrytangyuan -themself un-reconciled -untracked v1 v1.0 v1.1 @@ -257,5 +237,4 @@ vendored nix.conf LDFlags dev -vendorSha256 dependabot diff --git a/docs/running-nix.md b/docs/running-nix.md index 7d1a6c955060..b51deaf6ade5 100644 --- a/docs/running-nix.md +++ b/docs/running-nix.md @@ -31,7 +31,7 @@ and replace the existing hash value. The almost exact same principles apply here, the only difference being you must change the `vendorHash` and the `sha256` fields. The `vendorHash` is a hash of the vendored dependencies while the `sha256` is for the sources fetched from the `fetchFromGithub` call. -### Why am I getting a vendorSha256 mismatch ? +### Why am I getting a `vendorSha256` mismatch ? Unfortunately, dependabot is not capable of upgrading flakes automatically, when the go modules are automatically upgraded the hash of the vendor dependencies changes but this change isn't automatically reflected in the nix file. The `vendorSha256` field that needs to diff --git a/test/e2e/signals_test.go b/test/e2e/signals_test.go index c7e92d115e0f..873c16014096 100644 --- a/test/e2e/signals_test.go +++ b/test/e2e/signals_test.go @@ -31,7 +31,7 @@ func (s *SignalsSuite) TestStopBehavior() { SubmitWorkflow(). WaitForWorkflow(fixtures.ToHaveRunningPod, killDuration). ShutdownWorkflow(wfv1.ShutdownStrategyStop). - WaitForWorkflow(killDuration + 10*time.Second). // this one takes especially long in CI + WaitForWorkflow(killDuration + 15*time.Second). // this one takes especially long in CI Then(). ExpectWorkflow(func(t *testing.T, m *metav1.ObjectMeta, status *wfv1.WorkflowStatus) { assert.Contains(t, []wfv1.WorkflowPhase{wfv1.WorkflowFailed, wfv1.WorkflowError}, status.Phase)