Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps-dev): downgrade all Storybook breakage from dependabot et al #567

Merged
merged 17 commits into from
Aug 22, 2024
Merged

fix(deps-dev): downgrade all Storybook breakage from dependabot et al #567

merged 17 commits into from
Aug 22, 2024

Commits on Jul 18, 2024

  1. fix(deps): downgrade all breakage from dependabot et al 

    - go back to Storybook v6 addons, matching the `storybook` dep
  - the addons were partially auto-upgraded to breaking versions by dependabot
- go back to Webpack v4, matching Storybook v6
  - this was also auto-upgraded to a breaking version by dependabot
  - go back to `ts-loader` v8, matching Webpack v4
    - and this too had a breaking dependabot upgrade

Signed-off-by: Anton Gilgur <[email protected]>
    @agilgur5
    agilgur5 committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    30acdb5 View commit details
    Browse the repository at this point in the history

  2. revert unrelated dep changes 

    Signed-off-by: Anton Gilgur <[email protected]>
    @agilgur5
    agilgur5 committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    233c828 View commit details
    Browse the repository at this point in the history

  3. revert the yarn.lock semver compatible changes as well 

    Signed-off-by: Anton Gilgur <[email protected]>
    @agilgur5
    agilgur5 committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    6470e20 View commit details
    Browse the repository at this point in the history

  4. and once more 

    Signed-off-by: Anton Gilgur <[email protected]>
    @agilgur5
    agilgur5 committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    25b3beb View commit details
    Browse the repository at this point in the history

  5. attempt to revert more unnecessary auto-made yarn.lock changes 

    Signed-off-by: Anton Gilgur <[email protected]>
    @agilgur5
    agilgur5 committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    e2f27ae View commit details
    Browse the repository at this point in the history

  6. some more 

    Signed-off-by: Anton Gilgur <[email protected]>
    @agilgur5
    agilgur5 committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    fa39e16 View commit details
    Browse the repository at this point in the history

  7. more 

    Signed-off-by: Anton Gilgur <[email protected]>
    @agilgur5
    agilgur5 committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    78a9486 View commit details
    Browse the repository at this point in the history

  8. set all storybook deps to 6.5.14 and ensure yarn.lock follows it 

    - the latter took some manual editing and resolutions until it got it, and now it reproduces the minimal variant

Signed-off-by: Anton Gilgur <[email protected]>
    @agilgur5
    agilgur5 committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    0d6fc93 View commit details
    Browse the repository at this point in the history

  9. more yarn.lock diff reduction 

    Signed-off-by: Anton Gilgur <[email protected]>
    @agilgur5
    agilgur5 committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    991775d View commit details
    Browse the repository at this point in the history

  10. more babel reduction 

    Signed-off-by: Anton Gilgur <[email protected]>
    @agilgur5
    agilgur5 committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    27113f8 View commit details
    Browse the repository at this point in the history

  11. more babel reduction 

    Signed-off-by: Anton Gilgur <[email protected]>
    @agilgur5
    agilgur5 committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    9a0affa View commit details
    Browse the repository at this point in the history

  12. more 

    Signed-off-by: Anton Gilgur <[email protected]>
    @agilgur5
    agilgur5 committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    d219d35 View commit details
    Browse the repository at this point in the history

  13. couple more iterations on that 

    Signed-off-by: Anton Gilgur <[email protected]>
    @agilgur5
    agilgur5 committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    ce69bfa View commit details
    Browse the repository at this point in the history

  14. migrate from @dump247/storybook-state to useState hook 

    - as per its archived docs
- tried to make the diff as small as possible

Signed-off-by: Anton Gilgur <[email protected]>
    @agilgur5
    agilgur5 committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    d7a4c73 View commit details
    Browse the repository at this point in the history

Commits on Jul 19, 2024

  1. import individual components from dir 

    - same as downstream in Workflows, in order to code split properly, can't use the `src/` or `src/components/` imports as they have side effects (and therefore can't be tree-shaken)
  - instead have to do individual component imports to tree shake properly

- this seems to substantially improve performance from lethargic minutes of loading on first page load to seconds
  - I believe Storybook tries to code split things itself, so maybe it was making a giant bundle for each story file?

Signed-off-by: Anton Gilgur <[email protected]>
    @agilgur5
    agilgur5 committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    6a82512 View commit details
    Browse the repository at this point in the history

  2. remove not working CSS test 

    - it was tested with and without the comment, to be specific
  - as well as several other ways

Signed-off-by: Anton Gilgur <[email protected]>
    @agilgur5
    agilgur5 committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    2f491b4 View commit details
    Browse the repository at this point in the history

  3. downgrade to storybook 6.5.0-beta.1 to get around telemetry bug 

    - per, well, my own SO answer: https://stackoverflow.com/a/78770854/3431180

- also remove old, no longer unused `@types/storybook*` deps
  - Storybook has types built-in now (and is written in TS, not sure if it wasn't before or something)

Signed-off-by: Anton Gilgur <[email protected]>
    @agilgur5
    agilgur5 committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    31cd421 View commit details
    Browse the repository at this point in the history