feat(argo-workflows): Add honorLabels parameter to Argo Workflows ServiceMonitor #2920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: venegator <[email protected]>
Signed-off-by: venegator <[email protected]>
Signed-off-by: venegator <[email protected]>
Signed-off-by: venegator <[email protected]>
venegator
requested review from
vladlosev,
jmeridth,
yu-croco and
tico24
as code owners
venegator
changed the title
kiblik
reviewed
Sep 12, 2024
Co-authored-by: kiblik <[email protected]> Signed-off-by: venegator <[email protected]>
yu-croco
changed the title
yu-croco
reviewed
Sep 12, 2024
Comment on lines
27
to
29
| {{- if .Values.controller.metricsConfig.honorLabels }} | ||
| honorLabels: true | ||
| {{- end }} |
There was a problem hiding this comment.
nit; what about this ?
- {{- if .Values.controller.metricsConfig.honorLabels }}
- honorLabels: true
+ honorLabels:{{ .Values.controller.metricsConfig.honorLabels }}
- {{- end }}There was a problem hiding this comment.
Nice one, just commited the change now
Signed-off-by: venegator <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist: