Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow specifying PropagationPolicy for deleting k8s resources #3376

Open
jonapgar-groupby opened this issue Nov 27, 2024 · 0 comments
Open
Labels
enhancement New feature or request

Comments

@jonapgar-groupby
Copy link

Is your feature request related to a problem? Please describe.
Currently, when you delete a resource using a Sensor, the default PropagationPolicy of foreground is used. This means some dependent resources are not deleted. For example, when deleting a job, the pod is not deleted. The failed pods accumulate in k8s.

Describe the solution you'd like
A field in the Sensor resource to specify the PropagationPolicy.

Currently the StandardK8sTrigger does not accept any DeleteOptions:
err = k8sTrigger.namespableDynamicClient.Namespace(namespace).Delete(ctx, obj.GetName(), metav1.DeleteOptions{})

Message from the maintainers:

If you wish to see this enhancement implemented please add a 👍 reaction to this issue! We often sort issues this way to know what to prioritize.

@jonapgar-groupby jonapgar-groupby added the enhancement New feature or request label Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant