Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add leader election envionment variables to make them configurable #3225

Closed
wants to merge 1 commit into from
Closed

feat: add leader election envionment variables to make them configurable #3225

wants to merge 1 commit into from

Conversation

ChenRussell
Copy link

@ChenRussell ChenRussell commented Aug 1, 2024 •
edited
Loading

Fix #3224

add leader election envionment variables to make LeaseDuration、RenewDeadline and RetryPeriod configurable

Checklist:

@whynowy
Copy link
Member

whynowy commented Aug 2, 2024

@ChenRussell - thanks, could you run make codegen to fix the ci?

@ChenRussell
Copy link
Author

@ChenRussell - thanks, could you run make codegen to fix the ci?

I can not fix this problem when I run make codegen:

./hack/generate-proto.sh
++++++++++++++++++++++++++++++++
++++ GENERATING PROTO FILES ++++
++++++++++++++++++++++++++++++++
package golang.org/x/tools/cmd/goimports: unrecognized import path "golang.org/x/tools/cmd/goimports": https fetch: Get "https://golang.org/x/tools/cmd/goimports?go-get=1": dial tcp 142.250.69.209:443: i/o timeout

@github-actions GitHub Actions
Copy link
Contributor

This Pull Request is stale because it has been open for 60 days with
no activity. It will be closed in 7 days if no further activity.

@github-actions github-actions bot added the stale label Nov 24, 2024
@github-actions github-actions bot closed this Dec 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whynowy whynowy Awaiting requested review from whynowy whynowy is a code owner

@ryancurrah ryancurrah Awaiting requested review from ryancurrah

Assignees
No one assigned
Labels
stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Expose leader election envionment variables to configure LeaseDuration、RenewDeadline and RetryPeriod
3 participants
@ChenRussell @whynowy @ryancurrah