Upgrading from 2.11 to 2.12, ApplicationSet selectors & matchExpressions

[esn89]

Hi there, I would like to upgrade to ArgoCD 2.12 and I see that the matchLabels and matchExpressions are affected.

https://argo-cd.readthedocs.io/en/stable/operator-manual/upgrading/2.11-2.12/#details

In my ApplicationSets, I have:

generators:
  - git:
      repoURL: https://bloop.git/
      revision: master
      files:
      - path: "asdf/foo/bar*.yaml"
    selector:
      matchExpressions:
      - key: metadata.labels.project
        operator: NotIn
        values:
          - boopity-bop

And I was wondering, what, if any changes needed to be done here, prior to upgrading to 2.12.

Thank you

[abhi-kapoor]

I am working on upgrading argocd to v2.12 and confirmed if this affects us by running the below query:

for AS in $(kubectl get applicationset -A -o name); do echo $AS && kubectl get $AS -n argocd -o json --show-managed-fields | jq ' select(.spec.template.spec.syncPolicy.syncOptions? // [] | index("ServerSideApply=true"))
  | .metadata.managedFields
  | map(select(.fieldsV1["f:spec"]["f:generators"]) | .manager)'; done

Basically, I am just checking if the application has ServerSideApply=true and listing all the managers owning the spec.generators. If you see only 1 manager for this field, then you are good and the change shouldn't impact you.

[esn89]

Thanks a million, @abhi-kapoor