From 27b088424567cbb4f4f451d6bcbc932526184f16 Mon Sep 17 00:00:00 2001
From: arellanog <arellanog@cent.gov.ar>
Date: Fri, 8 Feb 2019 23:47:21 -0300
Subject: [PATCH] Improves default rules for PHPMD

---
 config/phpmd.xml | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)

diff --git a/config/phpmd.xml b/config/phpmd.xml
index a2b727f..0806eac 100644
--- a/config/phpmd.xml
+++ b/config/phpmd.xml
@@ -10,15 +10,12 @@
         PHPMD custom rule set for Symfony projects
     </description>
 
-    <rule ref="rulesets/cleancode.xml">
-        <exclude name="BooleanArgumentFlag" />
-        <exclude name="ElseExpression" />
-    </rule>
     <rule ref="rulesets/naming.xml">
         <exclude name="ShortVariable"/>
         <exclude name="LongVariable"/>
+        <exclude name="BooleanGetMethodName"/>
     </rule>
-    <!-- Redefining ShortVariable excluding $id and $em  -->
+    <!-- Redefining ShortVariable excluding $id, $em and $qb common in Symfony projects -->
     <rule ref="rulesets/naming.xml/ShortVariable"
           since="0.2"
           message="Avoid variables with short names like {0}. Configured minimum length is {1}."
@@ -27,7 +24,7 @@
         <priority>3</priority>
         <properties>
             <property name="minimum" description="Minimum length for a variable, property or parameter name" value="3"/>
-            <property name="exceptions" value="id,em" />
+            <property name="exceptions" value="id,em,qb" />
         </properties>
     </rule>
     <rule ref="rulesets/unusedcode.xml"/>