Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTP server #33

Open
daykin opened this issue Nov 2, 2023 · 7 comments
Open

HTTP server #33

daykin opened this issue Nov 2, 2023 · 7 comments

Comments

@daykin
Copy link

daykin commented Nov 2, 2023

Hello,

Is the 'nullhttpd' component of this plugin still maintained? On our site-specific version, there is a patch from 2018 (before my time) that switched everything over to GNU Microhttpd instead. Thus, everything we've added (i.e. compatibility with newer FFMpeg versions) uses Microhttpd. I'm trying to gather information about the rationale for this switch.

@coretl
Copy link
Contributor

coretl commented Nov 3, 2023

I believe that nullhttpd was abandoned shortly after this was originally written, hence the copy of the nullhttpd source code into this repo. Does Microhttpd work on Windows too? If so then it sounds like an ideal replacement.

@daykin
Copy link
Author

daykin commented Nov 3, 2023

according to the project page, yes. Do you happen to have a Windows testing environment handy? I can send the patch over if so. Otherwise I can probably get one set up and check it out.

@coretl
Copy link
Contributor

coretl commented Nov 3, 2023

Do you happen to have a Windows testing environment handy?

Unfortunately not. Although I'm the original developer of this module, I've moved jobs since I wrote it, so it would be up to someone else to make and test the changes. I was just commenting as I know the history...

@MarkRivers
Copy link
Member

I have a Windows test environment if you need me to test.

@daykin
Copy link
Author

daykin commented Nov 3, 2023

Thanks, Mark. Here is the patch:
microhttpd.patch

@MarkRivers
Copy link
Member

@daykin can you do this as a pull-request?

@daykin
Copy link
Author

daykin commented Nov 3, 2023

Sure. #34

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants