Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HttpClient.h file name conflicts with ESP32-Arduino framework #91

Closed
Panometric opened this issue Sep 1, 2020 · 2 comments · May be fixed by #123
Closed

HttpClient.h file name conflicts with ESP32-Arduino framework #91

Panometric opened this issue Sep 1, 2020 · 2 comments · May be fixed by #123

Comments

@Panometric
Copy link

Using ESP 32 Ardiono framework and platformio.org's library search functionality presents a vexing problem since the name HttpClient.h is duplicated in the ESP32 Arduino framework.

If you try to use both, the ArduinoHttpClient overrides the platform default, so it breaks anything else that uses HttpClient.h. Note that despite the cases of the classes being different, at least on windows the case of the filename does not matter, so the wrong file is included in any module that references it.

I was finally able to workarourd this my renaming the HttpClient.h -> MCQN_HttpClient.h . Your method may vary, but since this framework and platformio are very popular, this library should really not duplicate the header filename.

@Bascy
Copy link

Bascy commented Apr 15, 2024

Any chance on merging this long time standing name conflict?
Or solving this problem in any other way, maybe adding new files that are just including these..

@per1234 per1234 linked a pull request Apr 15, 2024 that will close this issue
@Panometric
Copy link
Author

Closed per #123

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants