Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use canonical null checks. #519

Open
fiseni opened this issue Apr 24, 2024 · 0 comments · May be fixed by #550
Open

Use canonical null checks. #519

fiseni opened this issue Apr 24, 2024 · 0 comments · May be fixed by #550

Comments

@fiseni
Copy link

fiseni commented Apr 24, 2024

We should update all null checks to use the canonical is null and is not null. This is especially important since we've extensively overloaded the operators in the library, and it's easy to introduce a trivial bug.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Updates appropriate null checks to all use pattern matching ArmoryNode/SmartEnum
1 participant
@fiseni