Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scry doesn't handle missing plugin descriptions correctly #4

Open
ardagnir opened this issue Mar 11, 2014 · 1 comment
Open

Scry doesn't handle missing plugin descriptions correctly #4

ardagnir opened this issue Mar 11, 2014 · 1 comment

Comments

@ardagnir
Copy link
Owner

It looks like vizardry handles plugins incorrectly in Scry if there missing descriptions.

Testcase: Scry markdown
dbeniamine added a commit to dbeniamine/vizardry that referenced this issue Jul 21, 2015
@dbeniamine
Fix issue ardagnir#4
1ffee76 
FIX: Scry troubles managing empty descriptions in plugin list,
see [issue ardagnir#4](ardagnir#4)
@dbeniamine
Copy link

Fixed by commit 1ffee76

The problem was that empty values in github search results looks likes:

"description": null,

While a normal answer looks like:

"description": "hello world",

Therefore replacing every null, by "", in the search result before creating list of plugins and description fix the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ardagnir @dbeniamine