Multiple tasks of same type only handled once per snowblock configuration file #76
Milestone
Comments
arcticicestudio
added a commit
that referenced
this issue
Jul 15, 2019
When a task is defined multiple times within the same snowblock
configuration file, only the last object was processed while any object
before has been ignored.
The root cause was the `pkg/snowblock.TaskRunnerMapping` (1) custom type
that only accepted one `pkg/api.TaskConfiguration` (2) object.
Therefore any parsed task object of the same type was overriden (2) by
tasks that are parsed after that task resulted in missing tasks.
Before this commit, running this example configuration has not processed
the first `clean` task but only the second one:
```json
[
{
"clean": ["~/desktop/failure"]
},
{
"link": {
"~/desktop/success/config.json": {
"create": true,
"path": "config.json"
}
}
},
{
"clean": ["~/desktop/success"]
},
]
```
To fix the problem the `pkg/snowblock.TaskRunnerMapping` type now
accepts multiple `pkg/api.TaskConfiguration` (2) objects
(`TaskRunnerMapping map[api.TaskRunner][]api.TaskConfiguration`) instead
of only one so the previous object won't be overridden.
References:
(1) https://github.com/arcticicestudio/snowsaw/blob/efdff96ec01f26bbf0a0d75bb9aab4cb86f023e8/pkg/snowblock/snowblock.go#L46
(2) https://github.com/arcticicestudio/snowsaw/blob/988073b1bde8d7db4b40f259e99d218c959bba8f/pkg/api/snowblock/task.go#L18
(3) https://github.com/arcticicestudio/snowsaw/blob/efdff96ec01f26bbf0a0d75bb9aab4cb86f023e8/pkg/snowblock/snowblock.go#L112
Epic: GH-33
Fixes GH-76
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When a task is defined multiple times within the same snowblock configuration file, only the last object is processed while any object before are ignored.
The root cause is the
pkg/snowblock.TaskRunnerMappingcustom type that only accepts onepkg/api.TaskConfigurationobject.Therefore any parsed task object of the same type is overriden by tasks that are parsed after that task resulting in missing tasks.
Running this example configuration will not process the first
cleantask but only the second one:[ { "clean": ["~/desktop/failure"] }, { "link": { "~/desktop/success/config.json": { "create": true, "path": "config.json" } } }, { "clean": ["~/desktop/success"] }, ]To fix this problem the
pkg/snowblock.TaskRunnerMappingtype should accept multiplepkg/api.TaskConfigurationobjects (TaskRunnerMapping map[api.TaskRunner][]api.TaskConfiguration) instead of only one so the previous object won't be overridden.The text was updated successfully, but these errors were encountered: