Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide strong guarantee for rad::Vector #27

Merged
merged 6 commits into from
Jul 10, 2024
Merged

Provide strong guarantee for rad::Vector #27

merged 6 commits into from
Jul 10, 2024

Conversation

adam-fonseca
Copy link
Contributor

  • Add overloads that provide the strong guarantee for types that can throw exceptions
  • Add test cases to verify the strong guarantee
  • Add fixture that checks to make sure all destructors are called
  • Refactor tests to verify a throwing type

@adam-fonseca
Provide strong guarantee for rad::Vector
f31b715 
* Add overloads that provide the strong guarantee for types that
  can throw exceptions
* Add test cases to verify the strong guarantee
* Add fixture that checks to make sure all destructors are called
* Refactor tests to verify a throwing type
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 10, 2024 •
edited
Loading

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@adam-fonseca
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@adam-fonseca
Copy link
Contributor Author

recheck

@codecov Codecov
Copy link

codecov bot commented Jul 10, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 84.42623% with 19 lines in your changes missing coverage. Please review.

Project coverage is 90.13%. Comparing base (afa1e0e) to head (81b9499).

Files Patch % Lines
radiant/detail/VectorOperations.h 82.24% 0 Missing and 19 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main      #27      +/-   ##
==========================================
- Coverage   90.94%   90.13%   -0.82%     
==========================================
  Files          17       18       +1     
  Lines        1922     1977      +55     
  Branches      236      257      +21     
==========================================
+ Hits         1748     1782      +34     
  Misses         13       13              
- Partials      161      182      +21

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adam-fonseca
Copy link
Contributor Author

recheck

@jxy-s jxy-s merged commit 11f033f into archonitelabs:main Jul 10, 2024
11 checks passed
@jxy-s jxy-s mentioned this pull request Jul 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jxy-s jxy-s jxy-s approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adam-fonseca @jxy-s