Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accession spawn Digital Object #22

Open
wants to merge 5 commits into
base: accession_archival_object_spawn
Choose a base branch
from

Conversation

kdimopulu
Copy link
Collaborator

No description provided.

@kdimopulu kdimopulu marked this pull request as draft November 11, 2024 09:28
@blacksmith-welder blacksmith-welder force-pushed the accession_spawn_digital_object_feature branch 2 times, most recently from 7d49047 to 4a58f9b Compare November 13, 2024 16:38
@blacksmith-welder blacksmith-welder changed the title Accession spawn Digital Object feature Accession spawn Digital Object Nov 13, 2024
@archivesspace archivesspace deleted a comment from kdimopulu Nov 14, 2024
@kdimopulu kdimopulu marked this pull request as ready for review November 14, 2024 12:40
@blacksmith-welder blacksmith-welder changed the base branch from master to accession_archival_object_spawn November 15, 2024 15:17
@blacksmith-welder blacksmith-welder changed the base branch from accession_archival_object_spawn to master November 15, 2024 15:17
@blacksmith-welder blacksmith-welder force-pushed the accession_spawn_digital_object_feature branch 2 times, most recently from 5505411 to 0cba333 Compare November 15, 2024 15:45
@blacksmith-welder blacksmith-welder changed the base branch from master to accession_archival_object_spawn November 15, 2024 16:27
@blacksmith-welder blacksmith-welder force-pushed the accession_spawn_digital_object_feature branch from 84b98d1 to a2db503 Compare November 15, 2024 17:09
@@ -22,6 +22,40 @@
click_on_string string
end

When 'the user clicks on the dropdown in the {string} form' do |form_title|
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would a form ever have two dropdowns?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It certainly could. Though it would be a bit more verbose, it might be good to rename this as "clicks on the first dropdown" just to make what it is doing clear.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many sub-record forms can have an arbitrary amount of dropdown buttons.

I have already considered this, and I have intentionally left it as it is because, at this point, all the created records have strictly one entry in each sub-record form.
This applies to other fields related to sub-records.

My intention was to elaborate further, once we are going to write features with more than one entry in sub-record forms, to devote more time and focus on a solution on how to effectively implement this.

Probably we are going to use words like first, second, etc., but numbering has to be scoped to refer to the entry inside a sub-record form because it is going to be cumbersome and error-prone to manually count dropdown buttons and/or fields.

eg.: It is going to be something like:
the user clicks on the second dropdown in the third entry in the Agent Links form

My suggestion is to leave it like this for now, to create some headroom for conceiving a clear and concise solution for all sub-records if possible.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm ok with having just this one step definition that clicks the first entry in the subrecord form, and we can of course consider alternatives in the future as needed. I still would prefer it to be named as such (clicks on the first dropdown) just to avoid confusion, especially since it is a shared step definition that may be used in a variety of contexts (including by test authors that may not be familiar with the Capybara end of things).

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@donaldjosephsmith
Copy link
Collaborator

Looks like there is now a small conflict that needs to be resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants