-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Accession spawn Digital Object #22
base: accession_archival_object_spawn
Are you sure you want to change the base?
Accession spawn Digital Object #22
Conversation
7d49047
to
4a58f9b
Compare
5505411
to
0cba333
Compare
00dced0
to
811c6ed
Compare
84b98d1
to
a2db503
Compare
staff_features/accessions/step_definitions/accession_spawn_digital_object.rb
Outdated
Show resolved
Hide resolved
811c6ed
to
595701b
Compare
8a316c5
to
2cac040
Compare
staff_features/accessions/step_definitions/accession_spawn_digital_object.rb
Show resolved
Hide resolved
@@ -22,6 +22,40 @@ | |||
click_on_string string | |||
end | |||
|
|||
When 'the user clicks on the dropdown in the {string} form' do |form_title| |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would a form ever have two dropdowns?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It certainly could. Though it would be a bit more verbose, it might be good to rename this as "clicks on the first dropdown" just to make what it is doing clear.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Many sub-record forms can have an arbitrary amount of dropdown buttons.
I have already considered this, and I have intentionally left it as it is because, at this point, all the created records have strictly one entry in each sub-record form.
This applies to other fields related to sub-records.
My intention was to elaborate further, once we are going to write features with more than one entry in sub-record forms, to devote more time and focus on a solution on how to effectively implement this.
Probably we are going to use words like first
, second
, etc., but numbering has to be scoped to refer to the entry inside a sub-record form because it is going to be cumbersome and error-prone to manually count dropdown buttons and/or fields.
eg.: It is going to be something like:
the user clicks on the second dropdown in the third entry in the Agent Links form
My suggestion is to leave it like this for now, to create some headroom for conceiving a clear and concise solution for all sub-records if possible.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm ok with having just this one step definition that clicks the first entry in the subrecord form, and we can of course consider alternatives in the future as needed. I still would prefer it to be named as such (clicks on the first dropdown
) just to avoid confusion, especially since it is a shared step definition that may be used in a variety of contexts (including by test authors that may not be familiar with the Capybara end of things).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
595701b
to
0281b03
Compare
Looks like there is now a small conflict that needs to be resolved. |
0281b03
to
cadbb5f
Compare
No description provided.