Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ANW-1799: Modify date calculator to handle child OA #3387

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Vchouliaras
Copy link
Collaborator

Description

Related JIRA Ticket or GitHub Issue

https://archivesspace.atlassian.net/browse/ANW-1799

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have read the CONTRIBUTING document.
  • I have authority to submit this code.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@Vchouliaras Vchouliaras force-pushed the ANW-1799-as-a-staff-user-i-dont-want-the-existing-date-subrecord-to-be-included-in-the-date-calculators-calculation branch from 283bb3e to a40ff5d Compare November 19, 2024 14:13
@Vchouliaras Vchouliaras marked this pull request as ready for review November 20, 2024 07:02
Copy link
Collaborator

@brianzelip brianzelip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Vchouliaras this looks good technically but I want to confer with archivists to get a better understanding of how the date calculator is used in practice. Will follow up with this next week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants