Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: MCPClient deploy still contains libxml2-utils #658

Closed
ross-spencer opened this issue Apr 18, 2019 · 5 comments
Closed

Problem: MCPClient deploy still contains libxml2-utils #658

ross-spencer opened this issue Apr 18, 2019 · 5 comments
Assignees
Milestone

Comments

@ross-spencer
Copy link
Contributor

ross-spencer commented Apr 18, 2019

Expected behaviour

When we install dependencies we are only installing what is absolutely needed by Archivematica.

Current behaviour

Because of the changes in #283 we may no longer need to be explicit about installing libxml2-utils.

The libxml2-utils package is still installed via here, here And here


For Artefactual use:
Please make sure these steps are taken before moving this issue from Review to Verified in Waffle:

  • All PRs related to this issue are properly linked 👍
  • All PRs related to this issue have been merged 👍
  • Test plan for this issue has been implemented and passed 👍
  • Documentation regarding this issue has been written and it has been added to the release notes, if needed 👍
@ross-spencer ross-spencer changed the title Problem: MCPClient Docker image still contains libxml2-utils Problem: MCPClient deploy still contains libxml2-utils Apr 18, 2019
@ross-spencer ross-spencer self-assigned this Apr 18, 2019
@ross-spencer ross-spencer added 3 - Review Status: review The issue's code has been merged and is ready for testing/review. and removed 3 - Review labels Apr 19, 2019
@ross-spencer ross-spencer added this to the 1.10.0 milestone Apr 19, 2019
@ross-spencer
Copy link
Contributor Author

Hi @sromkey adding 1.10 milestone as this was maintenance work that was a result of the custom structmap feature development: #283 and was resolved in PR #1409.

@sallain
Copy link
Member

sallain commented Jul 15, 2019

@ross-spencer how can this be tested?

@ross-spencer
Copy link
Contributor Author

Hi @sallain one way to do this would be to ssh into the deployment, and try and run xmllint. On my personal machine where it is installed still, I get this output:

$ xmllint --version
xmllint: using libxml version 20904
   compiled with: Threads Tree Output Push Reader Patterns Writer SAXv1 FTP HTTP DTDValid HTML Legacy C14N Catalog XPath XPointer XInclude Iconv ICU ISO8859X Unicode Regexps Automata Expr Schemas Schematron Modules Debug Zlib Lzma 

But you would see that the command cannot be found.

It was previously used for the microservice job: Job Verify mets_structmap.xml compliance but there wasn't a lot of output that would indicate this utility was being used vs. the replacement.

@sallain
Copy link
Member

sallain commented Jul 15, 2019

I get xmllint: not found errors so I'm going to go ahead and assume that this one is done 🙂

@ross-spencer
Copy link
Contributor Author

Errors FTW!

@sallain sallain closed this as completed Jul 15, 2019
@sallain sallain removed the Status: review The issue's code has been merged and is ready for testing/review. label Jul 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants