Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NeoForge 1.20.2 Holder does not implement Supplier, resulting in FluidStack crash. #484

Closed
brandon3055 opened this issue Mar 17, 2024 · 3 comments · Fixed by #485
Closed

Comments

@brandon3055
Copy link

In NeoForge 20.2.59-beta Supplier was removed from net.minecraft.core.Holder

Commit: neoforged/NeoForge@ed1b477

This is the patch that was removed:
https://github.com/neoforged/NeoForge/blob/1ba480f54685088db109e719081d23fb5bc3848e/patches/net/minecraft/core/Holder.java.patch

As a result, FluidStack creation via FluidStack#create(FluidStack, long) crashes with:
java.lang.IncompatibleClassChangeError: Class net.minecraft.core.Holder$Reference does not implement the requested interface java.util.function.Supplier
Full Crash: https://ss.brandon3055.com/ebe85

@Jab125
Copy link
Member

Jab125 commented Mar 17, 2024

wasn't that fixed in #483?

@brandon3055
Copy link
Author

wasn't that fixed in #483?

That fix appears to be for 1.20.4, It's still broken in 1.20.2

@shedaniel
Copy link
Member

Should be closed by #485

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants