From 4ba03bdf29455148b5d2c0323a40ffb65f362e43 Mon Sep 17 00:00:00 2001
From: Phillipus <p.beauvoir@dadabeatnik.com>
Date: Mon, 25 Nov 2024 12:01:40 +0000
Subject: [PATCH] Add support for Mockito/ByteBuddy requiring javaagent on Java
 21

- See https://github.com/mockito/mockito/issues/3037
- See https://javadoc.io/doc/org.mockito/mockito-core/latest/org/mockito/Mockito.html#0.3
- Requires Mockito 5.14.0 or later which allows you to specify Mockito itself as an agent rather than ByteBuddy

- Note - all test plug-ins need to declare a dependency on Mockito so that the mockito jar property ${org.mockito:mockito-core:jar} is always resolved for each test run

- To run JUnit in Eclipse you need to add the following VM arguments (adjust path version as required):

-Xshare:off
-javaagent:${workspace_loc}/.metadata/.plugins/org.eclipse.pde.core/.bundle_pool/plugins/org.mockito.mockito-core_5.14.2.jar

- Or, for now, it's simpler to add the following VM arguments:

-Xshare:off
-XX:+EnableDynamicAgentLoading
---
 .github/workflows/tests.yml                   |  2 +-
 com.archimatetool.editor.product/archi.target |  4 +--
 tests/pom.xml                                 | 32 ++++++++++++++++---
 3 files changed, 30 insertions(+), 8 deletions(-)

diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml
index 39d4741fe..e7e6eb1e1 100644
--- a/.github/workflows/tests.yml
+++ b/.github/workflows/tests.yml
@@ -14,7 +14,7 @@ jobs:
     - name: Set up Java
       uses: actions/setup-java@v4
       with:
-        java-version: '17'
+        java-version: '21'
         distribution: 'temurin'
         cache: 'maven'
       
diff --git a/com.archimatetool.editor.product/archi.target b/com.archimatetool.editor.product/archi.target
index e301a7b4b..02b8ff379 100644
--- a/com.archimatetool.editor.product/archi.target
+++ b/com.archimatetool.editor.product/archi.target
@@ -10,8 +10,8 @@
         <unit id="org.eclipse.jgit.ssh.apache.feature.group" version="6.10.0.202406032230-r"/>
     </location>
     <location includeAllPlatforms="false" includeConfigurePhase="true" includeMode="planner" includeSource="true" type="InstallableUnit">
-        <repository location="https://download.eclipse.org/tools/orbit/simrel/orbit-aggregation/release/4.32.0"/>
-        <unit id="org.mockito.mockito-core" version="5.12.0"/>
+        <repository location="https://download.eclipse.org/tools/orbit/simrel/orbit-aggregation/release/4.34.0"/>
+        <unit id="org.mockito.mockito-core" version="5.14.2"/>
     </location>
 </locations>
 </target>
\ No newline at end of file
diff --git a/tests/pom.xml b/tests/pom.xml
index bbe611cb3..14b618af3 100644
--- a/tests/pom.xml
+++ b/tests/pom.xml
@@ -12,13 +12,21 @@
 
     <artifactId>com.archimatetool.testing</artifactId>
     <packaging>pom</packaging>
-
+    
+    <properties>
+        <!-- Mockito/ByteBuddy needs this on Java 21+ -->
+        <mockito.args>-Xshare:off -javaagent:${org.mockito:mockito-core:jar}</mockito.args>
+        
+        <!-- <tycho.testArgLine> is passed as <argLine> to tycho-surefire-plugin -->
+        <tycho.testArgLine>${mockito.args}</tycho.testArgLine>
+    </properties>
+    
     <!-- Orbit p2 repo provides Mockito and latest JUnit for tests -->
     <repositories>
         <repository>
             <id>Orbit</id>
             <layout>p2</layout>
-            <url>https://download.eclipse.org/tools/orbit/simrel/orbit-aggregation/release/4.32.0</url>
+            <url>https://download.eclipse.org/tools/orbit/simrel/orbit-aggregation/release/4.34.0</url>
         </repository>
     </repositories>
 
@@ -26,8 +34,8 @@
         <module>com.archimatetool.testsupport</module>
 
         <module>com.archimatetool.canvas.tests</module>
-        <module>com.archimatetool.csv.tests</module>
         <module>com.archimatetool.commandline.tests</module>
+        <module>com.archimatetool.csv.tests</module>
         <module>com.archimatetool.editor.tests</module>
         <module>com.archimatetool.export.svg.tests</module>
 		<module>com.archimatetool.hammer.tests</module>
@@ -43,6 +51,20 @@
 
     <build>
         <plugins>
+            <!-- With this we can resolve ${org.mockito:mockito-core:jar} -->
+            <plugin>
+                <groupId>org.apache.maven.plugins</groupId>
+                <artifactId>maven-dependency-plugin</artifactId>
+                <version>3.8.1</version>
+                <executions>
+                    <execution>
+                        <goals>
+                            <goal>properties</goal>
+                        </goals>
+                    </execution>
+                </executions>
+            </plugin>
+            
             <plugin>
                 <groupId>org.eclipse.tycho</groupId>
                 <artifactId>tycho-surefire-plugin</artifactId>
@@ -59,14 +81,14 @@
     <profiles>
 	    <!-- Profile for Mac. <tycho.testArgLine> is passed as <argLine> to tycho-surefire-plugin -->
         <profile>
-            <id>osx</id>
+            <id>mac</id>
             <activation>
                 <os>
                     <family>mac</family>
                 </os>
             </activation>
             <properties>
-                <tycho.testArgLine>-XstartOnFirstThread</tycho.testArgLine>
+                <tycho.testArgLine>-XstartOnFirstThread ${mockito.args}</tycho.testArgLine>
             </properties>
         </profile>
     </profiles>