Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bundle and declaration improvements #68

Merged
merged 7 commits into from
Aug 11, 2023
Merged

bundle and declaration improvements #68

merged 7 commits into from
Aug 11, 2023

Conversation

bnjm
Copy link
Contributor

@bnjm bnjm commented Aug 11, 2023

This is a collection of improvements to resolve the issues in AL-4719:

There are a few issues with the package.json for honeycomb, preventing us from getting any type inference for honeycomb components on the frontend:

Audit from arethetypeswrong: https://arethetypeswrong.github.io/?p=%40archilogic%2Fhoneycomb%402.4.2

Audit from publint (npx publint):

Errors:

1. pkg.exports["."].types is ./dist/index.d.ts but the file does not exist.
2. pkg.exports["./components"].types is ./dist/components/index.d.ts but the file does not exist.
3. pkg.exports["./composables"].types is ./dist/composables/index.d.ts but the file does not exist.
4. pkg.types is ./dist/index.d.ts but the file does not exist.

Additionally, no component-level type information is emitted, so all components are marked as unknown

Grouping into 1 PR for simplicity, but can be reviewed by commit:

The two important changes:

  • exposing @archilogic/honeycomb/colors (1f9e93f)
  • emitting component types via a post-build pass with vue-tsc (e0e96e4). This is in addition to the exist vite-plugin-dts pass. I couldn't find a way to work with only one or the other, hopefully we can simplify it to one pass in the future.

@bnjm bnjm requested a review from a team August 11, 2023 12:06
Copy link
Contributor

@luk-zap luk-zap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💪

Copy link
Contributor

@romiekos romiekos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Don't forget to use the conventional commit ;)

@bnjm bnjm merged commit fdc5350 into main Aug 11, 2023
1 check passed
@bnjm bnjm deleted the bundle-improvements branch August 11, 2023 14:58
@github-actions
Copy link

🎉 This PR is included in version 2.5.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants