From 977987722c5161d2c15cb54de12f7db597770349 Mon Sep 17 00:00:00 2001
From: iana <filonenko.jana@gmail.com>
Date: Thu, 8 Feb 2024 15:39:41 +0100
Subject: [PATCH] feat(app-menu-item): render `a-keyboard-shortcut` if
 'shortcut' prop is provided

---
 src/components/AppMenuItem.vue             | 17 ++++++++--
 src/stories/AppMenu/AppMenuItem.stories.ts | 39 +++++++++++++++++++++-
 2 files changed, 52 insertions(+), 4 deletions(-)

diff --git a/src/components/AppMenuItem.vue b/src/components/AppMenuItem.vue
index 8aa61fd..0a99318 100644
--- a/src/components/AppMenuItem.vue
+++ b/src/components/AppMenuItem.vue
@@ -4,10 +4,11 @@ import { useElementBounding } from '@vueuse/core'
 
 import AIcon from './Icon.vue'
 import ArrowKeyFocusable from './ArrowKeyFocusable.vue'
+import { type Shortcut, default as KeyboardShortcut } from './KeyboardShortcut.vue'
 
 export default defineComponent({
   name: 'AAppMenuItem',
-  components: { AIcon, ArrowKeyFocusable },
+  components: { AIcon, ArrowKeyFocusable, KeyboardShortcut },
   props: {
     disabled: {
       type: Boolean,
@@ -29,8 +30,12 @@ export default defineComponent({
       type: String as PropType<'radio' | 'checkbox' | ''>,
       default: ''
     },
+    /**
+     * type `string` for shortcut prop is deprecated,
+     * use type `Shortcut` or `Shortcut[]` instead to
+     */
     shortcut: {
-      type: String,
+      type: [String, Object, Array] as PropType<string | Shortcut | Shortcut[]>,
       default: ''
     },
     /**
@@ -225,7 +230,13 @@ export default defineComponent({
       </div>
       <div class="mr-2 flex w-fit shrink-0 items-center gap-2">
         <slot name="extra"></slot>
-        <kbd v-if="shortcut" class="text-warsaw body-sm">{{ shortcut }}</kbd>
+        <KeyboardShortcut
+          v-if="shortcut"
+          :class="disabled && '!text-warsaw'"
+          variant="subtle"
+          :shortcut="
+            typeof shortcut === 'string' ? { keySequence: shortcut } : shortcut
+          "></KeyboardShortcut>
       </div>
       <template v-if="$slots.submenu">
         <a-icon name="MenuChevronRight" size="other" class="mr-2"></a-icon>
diff --git a/src/stories/AppMenu/AppMenuItem.stories.ts b/src/stories/AppMenu/AppMenuItem.stories.ts
index c47404b..8a90f41 100644
--- a/src/stories/AppMenu/AppMenuItem.stories.ts
+++ b/src/stories/AppMenu/AppMenuItem.stories.ts
@@ -182,7 +182,44 @@ export const Shortcut: Story = {
             <AAppMenuButton :open="open" v-bind="aria">Edit</AAppMenuButton>
           </template>
           <AAppMenuItem>Cut</AAppMenuItem>
-          <AAppMenuItem shortcut="Ctrl C">
+          <AAppMenuItem :shortcut="{modifiers: ['ctrl'], keySequence: 'c'}">
+            Copy
+          </AAppMenuItem>
+          <AAppMenuItem>Status</AAppMenuItem>
+        </AAppMenu>
+      `
+  }),
+  play: openMenu
+}
+export const MultipleShortcuts: Story = {
+  render: () => ({
+    components: { AAppMenu, AAppMenuItem, AAppMenuButton },
+    template: `
+        <AAppMenu>
+          <template #menu-button="{open, aria}">
+            <AAppMenuButton :open="open" v-bind="aria">Edit</AAppMenuButton>
+          </template>
+          <AAppMenuItem>Cut</AAppMenuItem>
+          <AAppMenuItem :shortcut="[{modifiers: ['ctrl'], keySequence: 'c'}, {modifiers: ['shift'], keySequence: 'c'}]">
+            Copy
+          </AAppMenuItem>
+          <AAppMenuItem>Status</AAppMenuItem>
+        </AAppMenu>
+      `
+  }),
+  play: openMenu
+}
+
+export const DisabledWithShortcuts: Story = {
+  render: () => ({
+    components: { AAppMenu, AAppMenuItem, AAppMenuButton },
+    template: `
+        <AAppMenu>
+          <template #menu-button="{open, aria}">
+            <AAppMenuButton :open="open" v-bind="aria">Edit</AAppMenuButton>
+          </template>
+          <AAppMenuItem>Cut</AAppMenuItem>
+          <AAppMenuItem disabled :shortcut="[{modifiers: ['ctrl'], keySequence: 'c'}, {modifiers: ['shift'], keySequence: 'c'}]">
             Copy
           </AAppMenuItem>
           <AAppMenuItem>Status</AAppMenuItem>