Fix filter to also take added entities into account #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This codes not work because the Added entity’s primary key value is wrong in it’s history without one more database roundtrip |
|
@Franklin89 There have any idea to fix the primary key value wrong issue? |
|
You got a valid point there!
Hmm i guess there is no solution other than hitting the database twice. In my case I use a GUID as an Id and create that in code on SaveChanges so this would not be an issue.
Idea: make the events configureable and leave added out of the standard configuration and let people decide if they want it.
…Sent from my iPhone
On 10 Sep 2018, at 4:23 AM, rigofunc ***@***.***> wrote:
@Franklin89 There have any idea to fix the primary key value wrong issue?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
Yeah, if the primary key isn't database generated, such as in your case, use code generated GUID, will not be an issue. Your idea could be impl in this PR? |
|
You mean the configuration? Sure, ill make an update asap! Maybe i can do it this afternoon (european time) 👍🏼
…Sent from my iPhone
On 10 Sep 2018, at 8:44 AM, rigofunc ***@***.***> wrote:
Yeah, if the primary key isn't database generated, such as in your case, use code generated GUID, will not be an issue.
Your idea could be impl in this PR?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
@Franklin89 Have you made any progress? |
|
Close because no more info |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #27