Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PT translation #195

Merged
merged 7 commits into from
Oct 4, 2024
Merged

Add PT translation #195

merged 7 commits into from
Oct 4, 2024

Conversation

giflw
Copy link
Contributor

@giflw giflw commented Sep 30, 2024

Add PT translation of arc42 template and help

@gernotstarke
Copy link
Member

Guilherme, thank you SOOO much for your valuable contribution. We are now looking for a brief review - as nobody from the core teams speaks/writes Portugese...

@gernotstarke gernotstarke self-assigned this Sep 30, 2024
@gernotstarke gernotstarke self-requested a review September 30, 2024 13:01
Copy link
Member

@gernotstarke gernotstarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@giflw could you please go over @pmattiollo comments, as you are the original author of the translation?

Copy link
Member

@gernotstarke gernotstarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanx to you both for your effort, highly appreciated from our side!!

I will approve the PR "as-is", and let @giflw decide which proposals to include.

We will "go live" with the current state!

@gernotstarke gernotstarke merged commit 04c9319 into arc42:master Oct 4, 2024
1 check passed
@giflw
Copy link
Contributor Author

giflw commented Nov 11, 2024

I'll make a new PR based on review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants