Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Operator to adjust scan pod resource requests and limits based on image size. #2267

Open
kchestnov opened this issue Sep 24, 2024 · 1 comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/stale Denotes an issue or PR has remained open with no activity and will be auto-closed.

Comments

@kchestnov
Copy link

The proposal is to detect image size before setting requests and limits for a scan job.

Currently the requests and limits are hardcoded and it makes it difficult to guess target resource requests required to schedule a pod when image sizes vary from MB to GB

If requests and limits are too low, then the pod will be OOMKIlled
If requests and limits are too high it is a waste of resources, in dynamic environment e.g. with use of Karpenter it will also use bigger nodes which cost more.

From my current understanding scan pod will require roughly the same amount of memory as the image it scans. Setting requests and limits a bit higher than the image size will help to optimize resource consumption.

@kchestnov kchestnov added the kind/feature Categorizes issue or PR as related to a new feature. label Sep 24, 2024
Copy link

This issue is stale because it has been labeled with inactivity.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and will be auto-closed. label Nov 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/stale Denotes an issue or PR has remained open with no activity and will be auto-closed.
Projects
None yet
Development

No branches or pull requests

1 participant