-
-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
exec fork bomb #3221
Comments
Thank you for your report. I'll take a look. $ pbpaste | grep -A 1 aquaproj/aqua
github.com/aquaproj/aqua/v2/pkg/osexec.Command({0xcee300?, 0xc00008bd80?}, {0xc00098a660?, 0xc0004c8b60?}, {0xc000390390?, 0xa3dac0?, 0x0?})
/home/runner/work/aqua/aqua/pkg/osexec/exec.go:29 +0x2b fp=0xc0004c8b10 sp=0xc0004c8ac0 pc=0x7d68cb
github.com/aquaproj/aqua/v2/pkg/controller/exec.(*Controller).execCommand(0xc000350360, {0xcee300, 0xc00008bd80}, {0xc00098a660?, 0xc00000a118?}, {0xc000390390?, 0xc000030440?, 0x1e?})
/home/runner/work/aqua/aqua/pkg/controller/exec/exec.go:131 +0xe5 fp=0xc0004c8b98 sp=0xc0004c8b10 pc=0x90d245
github.com/aquaproj/aqua/v2/pkg/controller/exec.(*Controller).execCommandWithRetry(0xc000350360, {0xcee300, 0xc00008bd80}, 0xc00039c0e0, {0xc00098a660, 0x1a}, {0xc000390390, 0x1, 0x1})
/home/runner/work/aqua/aqua/pkg/controller/exec/exec.go:146 +0x14f fp=0xc0004c8ec8 sp=0xc0004c8b98 pc=0x90d4ef
github.com/aquaproj/aqua/v2/pkg/controller/exec.(*Controller).Exec(0xc000350360, {0xcee300, 0xc00008bd80}, 0xc00039c0e0, 0xc00036e9a0, {0xc00000a118, 0x8}, {0xc000390390, 0x1, 0x1})
/home/runner/work/aqua/aqua/pkg/controller/exec/exec.go:44 +0x805 fp=0xc0004c9370 sp=0xc0004c8ec8 pc=0x90c685
github.com/aquaproj/aqua/v2/pkg/cli/exec.(*command).action(0xc000078560, 0xc00037a2c0)
/home/runner/work/aqua/aqua/pkg/cli/exec/command.go:57 +0x3e5 fp=0xc0004c9458 sp=0xc0004c9370 pc=0x969845
github.com/aquaproj/aqua/v2/pkg/cli/exec.(*command).action-fm(0xc0002f5670?)
<autogenerated>:1 +0x26 fp=0xc0004c9478 sp=0xc0004c9458 pc=0x969946
--
github.com/aquaproj/aqua/v2/pkg/cli.Run({0xcee300, 0xc00008bd80}, 0xc00008d0e0, {0xc0000aa000, 0x5, 0x8})
/home/runner/work/aqua/aqua/pkg/cli/runner.go:111 +0x825 fp=0xc0004c9d08 sp=0xc0004c99c8 pc=0x96fd05 aqua/pkg/controller/exec/exec.go Line 131 in ab6cd12
Lines 28 to 29 in ab6cd12
|
The log looks strange. aqua/pkg/controller/exec/exec.go Lines 144 to 154 in ab6cd12
The log |
I couldn't reproduce the issue on GitHub Actions' windows-latest. runneradmin@fv-az1785-293 MINGW64 /d/a/aqua-registry/aqua-registry/workspace
# node -v
INFO[0000] download and unarchive the package aqua_version=2.36.2 env=windows/amd64 exe_name=node package_name=nodejs/node package_version=v23.1.0 program=aqua registry=standard
v23.1.0
runneradmin@fv-az1785-293 MINGW64 /d/a/aqua-registry/aqua-registry/workspace
# xq --help
INFO[0000] download and unarchive the package aqua_version=2.36.2 env=windows/amd64 exe_name=xq package_name=MiSawa/xq package_version=v0.4.1 program=aqua registry=standard
A reimplementation of jq.
Usage: xq.exe [OPTIONS] [QUERY]
Arguments:
[QUERY] The query to run [default: .]
Options:
-f, --from-file <file> Read query from a file instead of arg
--input-format <INPUT_FORMAT> Specify input format [default: json] [possible values: json, yaml]
--json-input Read input as json values
--yaml-input Read input as yaml values
-R, --raw-input Treat each line of input will be supplied to the filter as a string. When used with --slurp, the whole input text will be supplied to the filter as a single string
-n, --null-input Single null is supplied to the program. The original input can still be read via input/0 and inputs/0
-s, --slurp Read input values into an array
--output-format <OUTPUT_FORMAT> Specify output format [default: json] [possible values: json, yaml]
--json-output Write output as json values
--yaml-output Write output as yaml values
-r, --raw-output Output raw string if the output value was a string
-c, --compact-output Compact output
-C, --color-output Colorize output where possible (currently only JSON is supported)
-M, --monochrome-output Do not colorize output
-v, --verbose... Increase logging verbosity
-q, --quiet... Decrease logging verbosity
-h, --help Print help
-V, --version Print version |
I checked the log. #3221 (comment) I can't find any issue at the code where the problem occurred. |
aqua info
Overview
Environment:
Running
node -v
to check its version string results in no output, until it crashes and quits silently. I've also tried this withxq
, with similar results, as I saw NodeJS support has its own implementation difficulties in the documentation.How to reproduce
aqua.yaml
Other related code such as local Registry: N/A
Executed command and output
Debug output
Expected behaviour
Node should run, printing its version string and exiting gracefully.
Actual behaviour
Aqua recursively calls itself, until exhausting the paging file and crashing.
Task Manager showing resource exhaustion, failing to draw graphs
GOTRACEBACK=1
outputNote
No response
The text was updated successfully, but these errors were encountered: