trivial: split out StoragePricing #11244

msmouse · 2023-12-07T23:31:34Z

Description

Split the pricing configs (StoragePricing) and change set limit configs (ChangeSetConfigs) to their own files.
Rename StoragePricing to IoPricing, in preparation to introduce space_pricing

Test Plan

existing coverage

trunk-io · 2023-12-07T23:31:38Z

⏱️ 14h 45m total CI duration on this PR

Job	Cumulative Duration	Recent Runs
rust-unit-tests	4h 9m	⬜ 🟩 🟩 ⬜ 🟩 (+6 more)
windows-build	3h 15m	🟩 🟩 🟩 🟩 🟩 (+6 more)
rust-images / rust-all	1h 36m	⬜ 🟩 🟩 ⬜ 🟩 (+6 more)
rust-lints	1h 18m	⬜ 🟩 🟩 ⬜ 🟩 (+6 more)
run-tests-main-branch	43m	🟩 🟩 🟩 ⬜ 🟩 (+6 more)
check	43m	⬜ 🟩 🟩 ⬜ 🟩 (+6 more)
forge-framework-upgrade-test / forge	33m	🟥
rust-smoke-tests	29m	🟩
general-lints	26m	🟩 🟩 🟩 ⬜ 🟩 (+6 more)
check-dynamic-deps	22m	🟩 🟩 🟩 🟩 🟩 (+6 more)
execution-performance / single-node-performance	18m	🟩
forge-e2e-test / forge	15m	🟩
forge-compat-test / forge	13m	🟩
cli-e2e-tests / run-cli-tests	9m	🟩
docs-lint	4m	🟩 🟩 🟩 🟩 🟩
semgrep/ci	4m	🟩 🟩 🟩 🟩 🟩 (+6 more)
file_change_determinator	2m	🟩 🟩 🟩 🟩 🟩 (+6 more)
file_change_determinator	2m	🟩 🟩 🟩 🟩 🟩 (+6 more)
file_change_determinator	2m	🟩 🟩 🟩 🟩 🟩 (+6 more)
node-api-compatibility-tests / node-api-compatibility-tests	50s	🟩
permission-check	35s	🟩 🟩 🟩 🟩 🟩 (+6 more)
permission-check	35s	🟩 🟩 🟩 🟩 🟩 (+6 more)
permission-check	34s	🟩 🟩 🟩 🟩 🟩 (+6 more)
determine-docker-build-metadata	31s	🟩 🟩 🟩 🟩 🟩 (+6 more)
permission-check	27s	🟩 🟩 🟩 🟩 🟩 (+6 more)
permission-check	25s	🟩 🟩 🟩 🟩 🟩 (+6 more)
execution-performance / file_change_determinator	11s	🟩
execution-performance / sequential-execution-performance	7s	🟩
execution-performance / parallel-execution-performance	7s	🟩

🚨 1 job on the last run was significantly faster/slower than expected

Job	Duration	vs 7d avg	Delta
forge-framework-upgrade-test / forge	33m	27m

_{settings ⋅ feedback ⋅ docs ⋅ learn more about trunk.io}

msmouse · 2023-12-07T23:31:45Z

Current dependencies on/for this PR:

main
- PR trivial: split out StoragePricing #11244 👈
  - PR Io Gas adjustments #11300
    - PR DiskSpacePricing #11262
      - PR Storage fee for state bytes refundable #11279
        
        PR (ignore) #11295
      - PR Remove per slot free quota for write gas #11278

This stack of pull requests is managed by Graphite.

github-actions · 2023-12-12T19:25:53Z

✅ Forge suite `compat` success on `aptos-node-v1.7.3` ==> `de475b694000af5ad16b38796b7938d100ec7926`

Compatibility test results for aptos-node-v1.7.3 ==> de475b694000af5ad16b38796b7938d100ec7926 (PR)
1. Check liveness of validators at old version: aptos-node-v1.7.3
compatibility::simple-validator-upgrade::liveness-check : committed: 5242 txn/s, latency: 6352 ms, (p50: 5700 ms, p90: 9300 ms, p99: 16300 ms), latency samples: 188720
2. Upgrading first Validator to new version: de475b694000af5ad16b38796b7938d100ec7926
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 1839 txn/s, latency: 15966 ms, (p50: 19000 ms, p90: 22200 ms, p99: 22300 ms), latency samples: 93800
3. Upgrading rest of first batch to new version: de475b694000af5ad16b38796b7938d100ec7926
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 1678 txn/s, latency: 17424 ms, (p50: 18900 ms, p90: 22300 ms, p99: 22600 ms), latency samples: 87300
4. upgrading second batch to new version: de475b694000af5ad16b38796b7938d100ec7926
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 2370 txn/s, latency: 9484 ms, (p50: 9800 ms, p90: 13800 ms, p99: 14200 ms), latency samples: 146980
5. check swarm health
Compatibility test for aptos-node-v1.7.3 ==> de475b694000af5ad16b38796b7938d100ec7926 passed
Test Ok

github-actions · 2023-12-12T19:27:31Z

✅ Forge suite `realistic_env_max_load` success on `de475b694000af5ad16b38796b7938d100ec7926`

two traffics test: inner traffic : committed: 8079 txn/s, latency: 4856 ms, (p50: 4500 ms, p90: 5700 ms, p99: 9800 ms), latency samples: 3490340
two traffics test : committed: 100 txn/s, latency: 2331 ms, (p50: 2200 ms, p90: 2600 ms, p99: 5600 ms), latency samples: 1740
Latency breakdown for phase 0: ["QsBatchToPos: max: 0.201, avg: 0.196", "QsPosToProposal: max: 0.154, avg: 0.148", "ConsensusProposalToOrdered: max: 0.574, avg: 0.564", "ConsensusOrderedToCommit: max: 0.557, avg: 0.525", "ConsensusProposalToCommit: max: 1.126, avg: 1.089"]
Max round gap was 1 [limit 4] at version 1634875. Max no progress secs was 4.666817 [limit 10] at version 1634875.
Test Ok

github-actions · 2023-12-12T19:45:38Z

❌ Forge suite `framework_upgrade` failure on `aptos-node-v1.7.3` ==> `de475b694000af5ad16b38796b7938d100ec7926`

Compatibility test results for aptos-node-v1.7.3 ==> de475b694000af5ad16b38796b7938d100ec7926 (PR)
Upgrade the nodes to version: de475b694000af5ad16b38796b7938d100ec7926
Test Failed: API error: Unknown error error sending request for url (http://aptos-node-3-validator.forge-framework-upgrade-pr-11244.svc:8080/v1/estimate_gas_price): error trying to connect: dns error: failed to lookup address information: Name or service not known

Stack backtrace:
   0: <unknown>
   1: <unknown>
   2: <unknown>
   3: <unknown>
   4: <unknown>
   5: <unknown>
   6: <unknown>
   7: <unknown>
   8: <unknown>
   9: <unknown>
  10: <unknown>
  11: <unknown>
  12: <unknown>
  13: __libc_start_main
  14: <unknown>
Trailing Log Lines:
   6: <unknown>
   7: <unknown>
   8: <unknown>
   9: <unknown>
  10: <unknown>
  11: <unknown>
  12: <unknown>
  13: __libc_start_main
  14: <unknown>


Swarm logs can be found here: See fgi output for more information.
thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: ApiError: namespaces "forge-framework-upgrade-pr-11244" not found: NotFound (ErrorResponse { status: "Failure", message: "namespaces \"forge-framework-upgrade-pr-11244\" not found", reason: "NotFound", code: 404 })

Caused by:
    namespaces "forge-framework-upgrade-pr-11244" not found: NotFound

Stack backtrace:
   0: <unknown>
   1: <unknown>
   2: <unknown>
   3: <unknown>
   4: <unknown>
   5: <unknown>
   6: <unknown>
   7: <unknown>
   8: <unknown>
   9: <unknown>
  10: <unknown>
  11: <unknown>
  12: <unknown>
  13: <unknown>
  14: <unknown>
  15: __libc_start_main
  16: <unknown>', testsuite/forge/src/backend/k8s/swarm.rs:676:18
stack backtrace:
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.
Debugging output:

msmouse force-pushed the 1206_refactor_pricing branch 2 times, most recently from 91011cc to 005f27e Compare December 8, 2023 01:14

msmouse requested a review from a team December 8, 2023 01:18

msmouse force-pushed the 1206_refactor_pricing branch from 005f27e to f2df38e Compare December 8, 2023 22:18

msmouse mentioned this pull request Dec 8, 2023

DiskSpacePricing #11262

Merged

msmouse requested a review from igor-aptos December 8, 2023 22:19

msmouse force-pushed the 1206_refactor_pricing branch from f2df38e to a978be3 Compare December 11, 2023 07:35

This was referenced Dec 11, 2023

Remove per slot free quota for write gas #11278

Closed

Storage fee for state bytes refundable #11279

Merged

msmouse force-pushed the 1206_refactor_pricing branch from a978be3 to 6806ce9 Compare December 11, 2023 17:08

msmouse mentioned this pull request Dec 12, 2023

(ignore) #11295

Merged

msmouse marked this pull request as ready for review December 12, 2023 00:50

msmouse requested review from davidiw, movekevin, wrwg and zekun000 as code owners December 12, 2023 00:50

msmouse mentioned this pull request Dec 12, 2023

Io Gas adjustments #11300

Merged

msmouse force-pushed the 1206_refactor_pricing branch 3 times, most recently from 4e833e9 to aacb739 Compare December 12, 2023 16:46

msmouse requested a review from vgao1996 December 12, 2023 16:57

trivial: split out StoragePricing

de475b6

areshand approved these changes Dec 12, 2023

View reviewed changes

grao1991 approved these changes Dec 12, 2023

View reviewed changes

msmouse force-pushed the 1206_refactor_pricing branch from aacb739 to de475b6 Compare December 12, 2023 19:00

msmouse enabled auto-merge (rebase) December 12, 2023 19:00

This comment has been minimized.

Sign in to view

msmouse merged commit b1f3abe into main Dec 12, 2023
69 of 84 checks passed

msmouse deleted the 1206_refactor_pricing branch December 12, 2023 19:34

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

trivial: split out StoragePricing #11244

trivial: split out StoragePricing #11244

msmouse commented Dec 7, 2023 •

edited

Loading

trunk-io bot commented Dec 7, 2023 •

edited

Loading

msmouse commented Dec 7, 2023 •

edited

Loading

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

github-actions bot commented Dec 12, 2023

github-actions bot commented Dec 12, 2023

github-actions bot commented Dec 12, 2023

trivial: split out StoragePricing #11244

trivial: split out StoragePricing #11244

Conversation

msmouse commented Dec 7, 2023 • edited Loading

Description

Test Plan

trunk-io bot commented Dec 7, 2023 • edited Loading

msmouse commented Dec 7, 2023 • edited Loading

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

github-actions bot commented Dec 12, 2023

✅ Forge suite compat success on aptos-node-v1.7.3 ==> de475b694000af5ad16b38796b7938d100ec7926

github-actions bot commented Dec 12, 2023

✅ Forge suite realistic_env_max_load success on de475b694000af5ad16b38796b7938d100ec7926

github-actions bot commented Dec 12, 2023

❌ Forge suite framework_upgrade failure on aptos-node-v1.7.3 ==> de475b694000af5ad16b38796b7938d100ec7926

msmouse commented Dec 7, 2023 •

edited

Loading

trunk-io bot commented Dec 7, 2023 •

edited

Loading

msmouse commented Dec 7, 2023 •

edited

Loading

✅ Forge suite `compat` success on `aptos-node-v1.7.3` ==> `de475b694000af5ad16b38796b7938d100ec7926`

✅ Forge suite `realistic_env_max_load` success on `de475b694000af5ad16b38796b7938d100ec7926`

❌ Forge suite `framework_upgrade` failure on `aptos-node-v1.7.3` ==> `de475b694000af5ad16b38796b7938d100ec7926`