Fix: Graph deleted before aptly exits #1214
Open
+114
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reglim
force-pushed
the
fix/1213-aptly-graph-removed-before-exiting
branch
6 times, most recently
from
8655777
to
7192f1e
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1214 +/- ##
==========================================
+ Coverage 74.82% 74.86% +0.03%
==========================================
Files 157 157
Lines 18176 18168 -8
==========================================
Hits 13601 13601
+ Misses 3468 3460 -8
Partials 1107 1107 ☔ View full report in Codecov by Sentry. |
randombenj
approved these changes
Sep 15, 2023
reglim
force-pushed
the
fix/1213-aptly-graph-removed-before-exiting
branch
from
7192f1e
to
486e864
Compare
neolynx
force-pushed
the
fix/1213-aptly-graph-removed-before-exiting
branch
from
2ee09ab
to
33fe7de
Compare
neolynx
force-pushed
the
fix/1213-aptly-graph-removed-before-exiting
branch
from
33fe7de
to
cc3403f
Compare
neolynx
force-pushed
the
fix/1213-aptly-graph-removed-before-exiting
branch
from
cc3403f
to
8a44c89
Compare
neolynx
force-pushed
the
fix/1213-aptly-graph-removed-before-exiting
branch
2 times, most recently
from
bf34f8a
to
9cb754a
Compare
neolynx
force-pushed
the
fix/1213-aptly-graph-removed-before-exiting
branch
from
9cb754a
to
be893e5
Compare
neolynx
force-pushed
the
fix/1213-aptly-graph-removed-before-exiting
branch
from
be893e5
to
446ada5
Compare
iofq
approved these changes
Nov 17, 2024
The temporary output file is now only deleted after copying it to the output location. Fixes: #1213
neolynx
force-pushed
the
fix/1213-aptly-graph-removed-before-exiting
branch
from
446ada5
to
0d28427
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1213
Requirements
All new code should be covered with tests, documentation should be updated. CI should pass.
Description of the Change
The temporary output file is now only deleted after copying it to the output location.
We no longer wait 1s for the open command, but exit immediately, since the process will continue running even after aptly exits.
Why this change is important?
Because the assumption was made that any application that opened the image would continue displaying it, even if the image was removed right after, which isn't true for the Gnome Image Viewer.
Checklist
AUTHORS