Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to latest official deck registration sheet #31

Open
tooomm opened this issue Nov 30, 2017 · 8 comments
Open

Update to latest official deck registration sheet #31

tooomm opened this issue Nov 30, 2017 · 8 comments

Comments

@tooomm
Copy link

tooomm commented Nov 30, 2017

Just tiny updates...
https://wpn.wizards.com/sites/wpn/files/attachements/mtg_constructed_deck_registration_sheet_pdf11.pdf

@Nightfirecat
Copy link
Contributor

Correct me if I'm wrong, but the three visible changes I can see (outside of spacing/fonts) are as follows:

  1. No "Table Number" and associated box at the top of the page
  2. Next to "Main Deck" header is an annotation saying "(Magic: 60 Minimum)"
  3. Next to "Sideboard" header is an annotation saying "(Magic: up to 15)"

@tooomm
Copy link
Author

tooomm commented Nov 30, 2017

  • The First Letter of Last Name box in the upper right has a colored background
    (same for First Name, Last Name and DCI#)
  • Hint that basic lands needs to be registerd as well! Main Deck Continued & Basic Lands:

Yes, and font type/size + spacing changes. # in deck is always underlined as well for example.

I couldn't overlay both files yet to see if all fields have the same position.
But regarding the changes I guess it should be more or less identical.

@Nightfirecat
Copy link
Contributor

Now that I've finally submitted #42, I plan on addressing this once I can get it merged.

@Nightfirecat
Copy link
Contributor

cc: @april

I'm inclined to say that for ease of printing, we shouldn't add the colored backgrounds. Given that our generated version already differs significantly (through small sizing/spacing differences) from the official copy, I feel we have some lenience in how we implement it.

That said, I agree the additional text and changed text should definitely match the new official sheet.

I'll likely work on this during the week and put in a PR over the weekend for this.

@april
Copy link
Owner

april commented Jun 7, 2018

I don't see any colored backgrounds, but I agree we should probably just stay grayscale. Overall I'm not too worried about it, given that our printouts already look way nicer than anything the official DCI list produces.

@Nightfirecat
Copy link
Contributor

I'm referring to the grey backgrounds of the last name, first name, DCI# and first-letter-of-last-name fields along the left side and the top of the official sheet. Ultimately, it's not hard for me to add them, I'm just on the fence about it given that we don't have any grey backgrounds in the current iteration of the jsPDF DCI sheet.

@april
Copy link
Owner

april commented Jun 7, 2018

Ehhhhhh, I would say we can leave them without the shading. They shading is mostly there because players overlook those fields a lot, which isn't really a problem on decklist.org.

@april
Copy link
Owner

april commented Jun 7, 2018

(also they look ugly, but you know that's just my opinion and all)

Nightfirecat added a commit to Nightfirecat/decklist that referenced this issue Jun 12, 2018
This removes the "Table number" box and text, adds the reminder
maindeck and sideboard count texts, and updates the "Maindeck continued"
header.

Closes april#31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants