Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add integration tests #25

Open
Nightfirecat opened this issue Jan 26, 2016 · 1 comment
Open

Add integration tests #25

Nightfirecat opened this issue Jan 26, 2016 · 1 comment

Comments

@Nightfirecat
Copy link
Contributor

Given past issues with cards with special characters—and the edge cases therein—and the implementation of error handling, we may benefit from starting to write a set of test cases to ensure we don't introduce regressions or partial fixes to these issues. (ref: #19, #24)

Since we can identify cards by their card name, we could confirm their inclusion in the computed deck list after parsing some given text. This would be a more secure and automated method of testing problem cases, rather than confirming by-eye.

IMO, this is a low-priority effort, but would be worth putting effort toward at some point in the future.

@Nightfirecat
Copy link
Contributor Author

We may be able to begin adding unit tests with the parsing changes of #42.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant