Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check the consistency of the symbolic circuit #316

Open
loreloc opened this issue Nov 10, 2024 · 0 comments
Open

Check the consistency of the symbolic circuit #316

loreloc opened this issue Nov 10, 2024 · 0 comments
Assignees
Labels
bug Something isn't working enhancement New feature or request

Comments

@loreloc
Copy link
Member

loreloc commented Nov 10, 2024

We do not check the consistency of the symbolic circuits before compilation.

Add the following checks in the __init__ method of the symbolic circuit:

  • Check the connections between layers and their arity. They must match.
  • Check the number of input units to each inner layer. They must match.
  • Check that inner layers have input connections, while input layers do not.
@loreloc loreloc self-assigned this Nov 10, 2024
@loreloc loreloc added bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request and removed documentation Improvements or additions to documentation labels Nov 10, 2024
@loreloc loreloc added this to the cirkit 0.2.0 (murmur) milestone Nov 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant