Feat whitelist enums #700
Merged
Feat whitelist enums #700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Eldad A. Fux <[email protected]>
Co-authored-by: Bishwajeet Parhi <[email protected]>
This reverts commit 7557829.
This reverts commit ea06f37.
Co-authored-by: Damodar Lohani <[email protected]>
lohanidamodar
approved these changes
Oct 30, 2023
Comment on lines
+109
to
+111
| protected function toUpperSnakeCase($str): string | ||
| { | ||
| return \strtoupper($this->toSnakeCase($str)); |
There was a problem hiding this comment.
do we really need this? Can we just not chain the twig filters directly
There was a problem hiding this comment.
We could chain them but I think it makes the templates/code easier to read if we just use one well-named filter
christyjacob4
approved these changes
Nov 3, 2023
# Conflicts: # templates/node/lib/client.js.twig # tests/DotNet31Test.php # tests/Go112Test.php # tests/Go118Test.php # tests/languages/ruby/tests.rb # tests/resources/spec.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
(Provide a description of what this PR does.)
Test Plan
(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work.)
Related PRs and Issues
(If this PR is related to any other PR or resolves any issue or related to any issue link all related PR and issues here.)
Have you read the Contributing Guidelines on issues?
(Write your answer here.)